Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing default value for skipUpgrade to fix flux errors #5368

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Mar 24, 2023

Description of changes:
Removing defaults for skipUpgrade to handle unpredictable behavior from Flux controller.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2023
@mitalipaygude
Copy link
Member

/lgtm

@pokearu
Copy link
Member Author

pokearu commented Mar 24, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pokearu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #5368 (f1702d1) into main (b527067) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5368      +/-   ##
==========================================
+ Coverage   72.48%   72.50%   +0.02%     
==========================================
  Files         440      440              
  Lines       36221    36282      +61     
==========================================
+ Hits        26256    26308      +52     
- Misses       8394     8400       +6     
- Partials     1571     1574       +3     
Impacted Files Coverage Δ
pkg/api/v1alpha1/cluster_types.go 81.96% <ø> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eks-distro-bot eks-distro-bot merged commit 5436cf1 into aws:main Mar 24, 2023
@mitalipaygude
Copy link
Member

/cherrypick release-0.15

@eks-distro-pr-bot
Copy link
Contributor

@mitalipaygude: new pull request created: #5374

In response to this:

/cherrypick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants