Add timeout to the e2e command #5642
Conversation
eks-distro-bot
added
the
size/XS
Codecov Report
@@ Coverage Diff @@
## main #5642 +/- ##
=======================================
Coverage 73.34% 73.34%
=======================================
Files 449 449
Lines 37297 37297
=======================================
Hits 27354 27354
Misses 8311 8311
Partials 1632 1632 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
internal/pkg/ssm/command.go
Outdated
| @@ -94,7 +94,7 @@ func RunCommand(session *session.Session, logger logr.Logger, instanceId, comman | |||
|
|
|||
| logger.Info("Waiting for ssm command to finish") | |||
| var commandOut *ssm.GetCommandInvocationOutput | |||
| r := retrier.New(300*time.Minute, retrier.WithMaxRetries(2160, 60*time.Second)) | |||
| r := retrier.New(310*time.Minute, retrier.WithMaxRetries(2160, 60*time.Second)) | |||
There was a problem hiding this comment.
I think we also need to update the SendCommandInput
I think we want go test timeout < SSM command timeout < timeout in retrier that pulls the SSM command results.
That guarantees the SSM command always gets the test results and that we always get the results of the SSM command.
There was a problem hiding this comment.
abhinavmpandey08
force-pushed
the
e2e-timeouts
branch
from
7b82033 to
d608bf5
Compare
eks-distro-bot
added
size/M
abhinavmpandey08
force-pushed
the
e2e-timeouts
branch
from
d608bf5 to
d8dc0f4
Compare
abhinavmpandey08
force-pushed
the
e2e-timeouts
branch
2 times, most recently
from
d38c3c2 to
248b2bd
Compare
abhinavmpandey08
force-pushed
the
e2e-timeouts
branch
from
248b2bd to
9202204
Compare
|
/approve |
|
@abhinavmpandey08: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abhinavmpandey08: new pull request created: #5649 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Add timeout to the e2e command. This makes sure that the e2e test command itself times out instead of the SSM command timing out. With this change, we will be able to get the results of the tests that finished even if the instance timed out.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.