-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs detailing how to uninstall EKS-A Cilium #5732
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5732 +/- ##
=======================================
Coverage 73.36% 73.36%
=======================================
Files 449 449
Lines 37388 37388
=======================================
Hits 27430 27430
Misses 8321 8321
Partials 1637 1637 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few suggestions.
cilium uninstall | ||
``` | ||
|
||
5. Install the custom CNI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would they know how to install the custom CNI? Would they follow instructions from here: https://github.com/cilium/cilium-cli?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the CNI they want to install. We don't prescribe what CNI they should use - this is all about enabling CNI customization - so they would need to reflect on the documentation for the CNI to install it successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is open ended, do we still support their EKS-A cluster regardless of what CNI they install? Is is partially supported, as in: We will support your cluster, but you must do all troubleshooting and maintenance of your CNI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csplinter is better positioned to answer that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion from @csplinter: I think adding this note to the cluster-replace-cilium.md is sufficient
Note: When replacing EKS Anywhere Cilium with a custom CNI, it is your responsibility to manage the custom CNI, including version upgrades and support.
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add docs detailing how to uninstall EKS-A Cilium * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/reference/clusterspec/optional/cni.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Improve replacing EKS-A Cilium guide * Add note clarifying support when replacing EKS-A Cilium --------- Co-authored-by: Chris Negus <striker57@gmail.com>
/cherry-pick release-0.15 |
@abhinavmpandey08: new pull request created: #5782 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Add docs detailing how to uninstall EKS-A Cilium * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/reference/clusterspec/optional/cni.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md Co-authored-by: Chris Negus <striker57@gmail.com> * Improve replacing EKS-A Cilium guide * Add note clarifying support when replacing EKS-A Cilium --------- Co-authored-by: Chris Negus <striker57@gmail.com>
#5731
Summary
This PR adds documentation detailing how a user can uninstall the EKS Anywhere Cilium CNI and provides e2e walk throughs of the process.