Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs detailing how to uninstall EKS-A Cilium #5732

Merged
merged 8 commits into from
May 2, 2023
Merged

Add docs detailing how to uninstall EKS-A Cilium #5732

merged 8 commits into from
May 2, 2023

Conversation

chrisdoherty4
Copy link
Contributor

@chrisdoherty4 chrisdoherty4 commented Apr 27, 2023

#5731

Summary

This PR adds documentation detailing how a user can uninstall the EKS Anywhere Cilium CNI and provides e2e walk throughs of the process.

@chrisdoherty4 chrisdoherty4 requested review from chrisnegus and a team April 27, 2023 21:41
@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #5732 (7f9137b) into main (b9c7528) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f9137b differs from pull request most recent head 398543c. Consider uploading reports for the commit 398543c to get more accurate results

@@           Coverage Diff           @@
##             main    #5732   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files         449      449           
  Lines       37388    37388           
=======================================
  Hits        27430    27430           
  Misses       8321     8321           
  Partials     1637     1637           

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few suggestions.

docs/content/en/docs/reference/clusterspec/optional/cni.md Outdated Show resolved Hide resolved
cilium uninstall
```

5. Install the custom CNI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would they know how to install the custom CNI? Would they follow instructions from here: https://github.com/cilium/cilium-cli?

Copy link
Contributor Author

@chrisdoherty4 chrisdoherty4 Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the CNI they want to install. We don't prescribe what CNI they should use - this is all about enabling CNI customization - so they would need to reflect on the documentation for the CNI to install it successfully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is open ended, do we still support their EKS-A cluster regardless of what CNI they install? Is is partially supported, as in: We will support your cluster, but you must do all troubleshooting and maintenance of your CNI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csplinter is better positioned to answer that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion from @csplinter: I think adding this note to the cluster-replace-cilium.md is sufficient

Note: When replacing EKS Anywhere Cilium with a custom CNI, it is your responsibility to manage the custom CNI, including version upgrades and support.

chrisdoherty4 and others added 5 commits April 28, 2023 11:15
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
Co-authored-by: Chris Negus <striker57@gmail.com>
@chrisnegus
Copy link
Member

/lgtm

@chrisdoherty4
Copy link
Contributor Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 742d4f8 into aws:main May 2, 2023
rahulbabu95 pushed a commit to rahulbabu95/eks-anywhere that referenced this pull request May 3, 2023
* Add docs detailing how to uninstall EKS-A Cilium

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/reference/clusterspec/optional/cni.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Improve replacing EKS-A Cilium guide

* Add note clarifying support when replacing EKS-A Cilium

---------

Co-authored-by: Chris Negus <striker57@gmail.com>
@abhinavmpandey08
Copy link
Member

/cherry-pick release-0.15

@eks-distro-pr-bot
Copy link
Contributor

@abhinavmpandey08: new pull request created: #5782

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ddjjia pushed a commit to ddjjia/eks-anywhere that referenced this pull request Jun 8, 2023
* Add docs detailing how to uninstall EKS-A Cilium

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/reference/clusterspec/optional/cni.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Update docs/content/en/docs/tasks/cluster/cluster-replace-cilium.md

Co-authored-by: Chris Negus <striker57@gmail.com>

* Improve replacing EKS-A Cilium guide

* Add note clarifying support when replacing EKS-A Cilium

---------

Co-authored-by: Chris Negus <striker57@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants