Refactoring to fail on vsphere perms validations #6188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
pokearu
added
the
area/providers/vsphere
Codecov Report
@@ Coverage Diff @@
## main #6188 +/- ##
==========================================
- Coverage 75.03% 75.01% -0.02%
==========================================
Files 448 448
Lines 37040 36971 -69
==========================================
- Hits 27792 27734 -58
- Misses 7673 7675 +2
+ Partials 1575 1562 -13
|
pkg/providers/vsphere/validator.go
Outdated
| privs, err = v.getMissingPrivs(ctx, vsc, path, t, privsContent, username) | ||
| if err != nil { | ||
| return passed, err | ||
| return passed, fmt.Errorf("failed to get missing privs: %v", err) |
There was a problem hiding this comment.
If this error is something we return to the users, should we be more explicit and say privileges or permissions?
Suggested change
| return passed, fmt.Errorf("failed to get missing privs: %v", err) | |
| return passed, fmt.Errorf("failed to get missing privileges: %v", err) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pokearu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mitalipaygude
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5865:
Description of changes:
Modified to fail on vsphere missing user permissions.
Testing:
Created a user with missing permissions and tested validations. Now the error shows as
2023-07-14T20:09:04.809Z V3 user ramaliar-test@vsphere.local missing vSphere permissions {"Permissions": "- username: ramaliar-test@vsphere.local\n objectType: Network\n path: /Denver/network/Dev\n permissions:\n - VirtualMachine.Interact.PowerOff\n - VirtualMachine.Interact.PowerOn\n- username: ramaliar-test@vsphere.local\n objectType: Datastore\n path: /Denver/datastore/datastore1.1\n permissions:\n - VirtualMachine.Interact.PowerOff\n - VirtualMachine.Interact.PowerOn\n- username: ramaliar-test@vsphere.local\n objectType: ResourcePool\n path: /Denver/host/EKS-A/Resources/CI\n permissions:\n - VirtualMachine.Interact.PowerOff\n - VirtualMachine.Interact.PowerOn\n- username: ramaliar-test@vsphere.local\n objectType: Folder\n path: /Denver/vm/Dev/capv/ramaliar\n permissions:\n - VirtualMachine.Interact.PowerOff\n - VirtualMachine.Interact.PowerOn\n- username: ramaliar-test@vsphere.local\n objectType: VirtualMachine\n path: /Denver/vm/Templates/bottlerocket-v1.25.11-kubernetes-1-25-eks-17-amd64-327823e\n permissions:\n - VirtualMachine.Interact.PowerOff\n - VirtualMachine.Interact.PowerOn\n- username: ramaliar-test@vsphere.local\n objectType: Folder\n path: /Denver/vm/Templates\n permissions:\n - VirtualMachine.Interact.PowerOff\n - VirtualMachine.Interact.PowerOn\n"} 2023-07-14T20:09:04.810Z V0 ❌ Validation failed {"validation": "vsphere Provider setup is valid", "error": "validating vsphere user privileges: user ramaliar-test@vsphere.local missing vSphere permissions", "remediation": ""}Tested creating a cluster
Documentation added/planned :
Plan to document the change in user experience.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.