Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting for control plane to be fully upgraded #6764

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

panktishah26
Copy link
Member

Issue #, if available:
A part of kindless upgrade task for management cluster: https://github.com/aws/eks-anywhere/blob/main/designs/kindless-upgrades.md#waiting-for-control-plane-to-be-fully-upgraded

Description of changes:
There a race condition where the status of the CAPI cluster is not updated fast enough after updating the KCP. Thus, before upgrading other components like CNI, worker nodes wait for CP to be fully upgraded before upgrading other components of the cluster. Now the controller will look at the KCP object instead of CAPI cluster to avoid outdated status reports.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 3, 2023
@panktishah26 panktishah26 force-pushed the wait-cp-upgrade-kindless branch from f3ef354 to 2efb3ea Compare October 4, 2023 00:51
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0d8519c) 75.67% compared to head (22ba7bf) 71.73%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6764      +/-   ##
==========================================
- Coverage   75.67%   71.73%   -3.94%     
==========================================
  Files         475      531      +56     
  Lines       38411    41064    +2653     
==========================================
+ Hits        29066    29456     +390     
- Misses       7733     9962    +2229     
- Partials     1612     1646      +34     
Files Coverage Δ
pkg/controller/clusters/clusterapi.go 91.42% <84.21%> (-8.58%) ⬇️

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the wait-cp-upgrade-kindless branch from 2efb3ea to 22ba7bf Compare October 4, 2023 01:06
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 5db1015 into aws:main Oct 4, 2023
5 checks passed
@panktishah26
Copy link
Member Author

/cherry-pick release-0.17

@eks-distro-pr-bot
Copy link
Contributor

@panktishah26: new pull request created: #7143

In response to this:

/cherry-pick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants