-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waiting for control plane to be fully upgraded #6764
Conversation
f3ef354
to
2efb3ea
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6764 +/- ##
==========================================
- Coverage 75.67% 71.73% -3.94%
==========================================
Files 475 531 +56
Lines 38411 41064 +2653
==========================================
+ Hits 29066 29456 +390
- Misses 7733 9962 +2229
- Partials 1612 1646 +34
☔ View full report in Codecov by Sentry. |
2efb3ea
to
22ba7bf
Compare
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.17 |
@panktishah26: new pull request created: #7143 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
A part of kindless upgrade task for management cluster: https://github.com/aws/eks-anywhere/blob/main/designs/kindless-upgrades.md#waiting-for-control-plane-to-be-fully-upgraded
Description of changes:
There a race condition where the status of the CAPI cluster is not updated fast enough after updating the KCP. Thus, before upgrading other components like CNI, worker nodes wait for CP to be fully upgraded before upgrading other components of the cluster. Now the controller will look at the KCP object instead of CAPI cluster to avoid outdated status reports.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.