Check for k8s version in the Cloudstack template name #7130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
cxbrowne1207
approved these changes
Dec 5, 2023
panktishah26
force-pushed
the
cloudstack-k8s-version-template-0.17
branch
from
7b8b033 to
a0e1173
Compare
panktishah26
force-pushed
the
cloudstack-k8s-version-template-0.17
branch
from
a0e1173 to
82ec8f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.17 #7130 +/- ##
================================================
+ Coverage 75.51% 75.53% +0.02%
================================================
Files 455 455
Lines 37922 37951 +29
================================================
+ Hits 28635 28667 +32
+ Misses 7676 7674 -2
+ Partials 1611 1610 -1 ☔ View full report in Codecov by Sentry. |
|
/test eks-anywhere-presubmit |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxbrowne1207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Template name field in each cloudstack machine object should contain Cluster object's kubernetes version and/or worker machine's kubernetes version.
Simple Upgrade:
Modular Upgrade:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.