Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.19] Fix cluster directory being created with root ownership #8121

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #8120

/assign chrisdoherty4

When hostpaths used for bind mounting in Docker don't exist at the time
the container is created, dockerd creates the directory. dockerd runs as
root on most systems hence the directory is created with root ownership.

This ensures the directory exists before we attempt to launch the tools
container that bind mounts the cluster directory.
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2024
@chrisdoherty4
Copy link
Contributor

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-0.19@f34868b). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.19    #8121   +/-   ##
===============================================
  Coverage                ?   73.47%           
===============================================
  Files                   ?      588           
  Lines                   ?    37188           
  Branches                ?        0           
===============================================
  Hits                    ?    27323           
  Misses                  ?     8069           
  Partials                ?     1796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot merged commit 3f508b9 into aws:release-0.19 May 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants