Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iam kubeconfig generation in workload clusters #9048

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Dec 6, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (e97188b) to head (a6b8317).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/clustermanager/cluster_manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9048      +/-   ##
==========================================
- Coverage   72.37%   72.36%   -0.01%     
==========================================
  Files         578      578              
  Lines       45436    45436              
==========================================
- Hits        32883    32880       -3     
- Misses      10823    10825       +2     
- Partials     1730     1731       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot
Copy link
Collaborator

@tatlat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-anywhere-presubmit a6b8317 link true /test eks-anywhere-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tatlat
Copy link
Member Author

tatlat commented Dec 6, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tatlat tatlat merged commit a53494e into aws:main Dec 6, 2024
9 of 12 checks passed
@tatlat
Copy link
Member Author

tatlat commented Dec 6, 2024

/cherry-pick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@tatlat: new pull request created: #9049

In response to this:

/cherry-pick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants