Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the need to use quotes around Kubernetes version #9175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhay-krishna
Copy link
Member

@abhay-krishna abhay-krishna commented Jan 16, 2025

Due to bugs (1, 2) in the underlying gopkg.in/yaml.v2 parser used by the sigs.k8s.io/yaml module (same issue also logged there) that we consume, the Kubernetes version with minor versions which is a multiple of 10, such as 1.30, 1.40, will be parsed as float64 if specified without quotes in the cluster config file, which causes the trailing zero to get dropped, thereby leading to 1.3, 1.4 which are incorrect. This can be prevented by using quotes around the Kubernetes version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from abhay-krishna. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.36%. Comparing base (79b3a53) to head (182c40d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9175      +/-   ##
==========================================
- Coverage   72.37%   72.36%   -0.01%     
==========================================
  Files         585      585              
  Lines       45713    45713              
==========================================
- Hits        33085    33082       -3     
- Misses      10890    10892       +2     
- Partials     1738     1739       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants