Document the need to use quotes around Kubernetes version #9175
+50
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bugs (1, 2) in the underlying
gopkg.in/yaml.v2
parser used by thesigs.k8s.io/yaml
module (same issue also logged there) that we consume, the Kubernetes version with minor versions which is a multiple of 10, such as1.30
,1.40
, will be parsed asfloat64
if specified without quotes in the cluster config file, which causes the trailing zero to get dropped, thereby leading to1.3
,1.4
which are incorrect. This can be prevented by using quotes around the Kubernetes version.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.