[aws-node-termination-handler] `ports` is defined twice in Helm template of DaemonSet

[alex-berger]

Describe the bug

The Helm templates for aws-node-termination-handler will produce invalid DaemonSet(s) and Deployment spec with duplicate ports key if values enableProbesServer and enablePrometheusServer are both set to true.

Here some pointers to the critical lines:

• https://github.com/aws/eks-charts/blob/v0.0.54/stable/aws-node-termination-handler/templates/daemonset.linux.yaml#L184
• https://github.com/aws/eks-charts/blob/v0.0.54/stable/aws-node-termination-handler/templates/daemonset.linux.yaml#L191
• https://github.com/aws/eks-charts/blob/v0.0.54/stable/aws-node-termination-handler/templates/daemonset.windows.yaml#L158
• https://github.com/aws/eks-charts/blob/v0.0.54/stable/aws-node-termination-handler/templates/daemonset.windows.yaml#L165
• https://github.com/aws/eks-charts/blob/v0.0.54/stable/aws-node-termination-handler/templates/deployment.yaml#L160
• https://github.com/aws/eks-charts/blob/v0.0.54/stable/aws-node-termination-handler/templates/deployment.yaml#L167

Steps to reproduce

Set both values enableProbesServer and enablePrometheusServer to true.

Expected outcome

If both values enableProbesServer and enablePrometheusServer are set to true the Helm templates should produce valid DaemonSet resp. Deployment spec which exposes two ports:

Environment

• Chart name: aws-node-termination-handler
• Chart version: 0.15.1
• Kubernetes version: 1.19.6
• Using EKS (yes/no), if so version? yes 1.19