Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aws-cloudwatch-metrics link in README #310

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

mforutan
Copy link
Contributor

Issue #, if available: none

Description of changes:

Noticed a broken link in the README for aws-cloudwatch-metrics

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@fawadkhaliq fawadkhaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it!

@fawadkhaliq
Copy link

@mforutan I missed this earlier (noticed in the CI failure) - you need to bump the chart version [1] as well (Chart aws-cloudwatch-metrics/ has the same Chart version as the last release..).

https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/Chart.yaml#L4

@mforutan
Copy link
Contributor Author

mforutan commented Jan 9, 2021

@mforutan I missed this earlier (noticed in the CI failure) - you need to bump the chart version [1] as well (Chart aws-cloudwatch-metrics/ has the same Chart version as the last release..).

https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/Chart.yaml#L4

@fawadkhaliq Thank you for the reminder, I fixed that but now it is complaining about a different chart, can you please have a look when you have a minute?

@mforutan
Copy link
Contributor Author

@fawadkhaliq now the CI issue is fixed on the master branch, this PR is ready to be merged, thank you.

@fawadkhaliq
Copy link

++ thanks!

@fawadkhaliq fawadkhaliq merged commit 28db445 into aws:master Jan 12, 2021
@mforutan mforutan deleted the fix-readme branch January 26, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants