Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-load-balancer-controller]Add PodDisruptionBudget #424

Merged

Conversation

cw-sakamoto
Copy link
Contributor

@cw-sakamoto cw-sakamoto commented Jan 15, 2021

Signed-off-by: cw-sakamoto sakamoto@chatwork.com

Description of changes

Add Pod Disruption Budget template

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

result with helm diff in our test cluster.

kube-system, aws-load-balancer-controller, PodDisruptionBudget (policy) has been added:
-
  1 awsLoadBalancerController:↲
+ # Source: aws-load-balancer-controller/templates/pdb.yaml
+ # Source: aws-load-balancer-controller/templates/pdb.yaml
+ apiVersion: policy/v1beta1
+ kind: PodDisruptionBudget
+ metadata:
+   name: aws-load-balancer-controller
+   labels:
+     helm.sh/chart: aws-load-balancer-controller-1.1.3
+     app.kubernetes.io/name: aws-load-balancer-controller
+     app.kubernetes.io/instance: aws-load-balancer-controller
+     app.kubernetes.io/version: "v2.1.1"
+     app.kubernetes.io/managed-by: Helm
+   namespace: kube-system
+ spec:
+   selector:
+     matchLabels:
+       app.kubernetes.io/name: aws-load-balancer-controller
+       app.kubernetes.io/instance: aws-load-balancer-controller
+   maxUnavailable: 1

result of describe during rolling update.

% kubectl describe pdb -n kube-system aws-load-balancer-controller
Name:             aws-load-balancer-controller
Namespace:        kube-system
Max unavailable:  1
Selector:         app.kubernetes.io/instance=aws-load-balancer-controller,app.kubernetes.io/name=aws-load-balancer-controller
Status:
    Allowed disruptions:  1
    Current:              2
    Desired:              1
    Total:                2
Events:                   <none>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: cw-sakamoto <sakamoto@chatwork.com>
@cw-sakamoto
Copy link
Contributor Author

@kishorj
Thank you for your maintenance of this chart. Please review this PR.

Copy link

@fawadkhaliq fawadkhaliq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++, thanks for your contribution!

cc: @Kishorb to take a final look

@@ -122,7 +122,7 @@ helm delete aws-load-balancer-controller -n kube-system
## Configuration

The following tables lists the configurable parameters of the chart and their default values.
The default values set by the application itself can be confirmed [here](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/guide/controller/configurations.md).
The default values set by the application itself can be confirmed [here](https://kubernetes-sigs.github.io/aws-load-balancer-controller/guide/controller/configurations/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishorj kishorj merged commit f634a86 into aws:master Jan 20, 2021
@cw-sakamoto cw-sakamoto deleted the add_pdb_aws-load-balancer-controller branch January 21, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants