Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-cloudwatch-metrics] Add optional priorityClassName #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/aws-cloudwatch-metrics/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: aws-cloudwatch-metrics
description: A Helm chart to deploy aws-cloudwatch-metrics project
version: 0.0.7
version: 0.0.8
appVersion: "1.247350"
home: https://github.com/aws/eks-charts
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
Expand Down
13 changes: 7 additions & 6 deletions stable/aws-cloudwatch-metrics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ helm upgrade --install aws-cloudwatch-metrics \
| `image.tag` | Image tag to deploy | `1.247345.36b249270`
| `image.pullPolicy` | Pull policy for the image | `IfNotPresent` | ✔
| `clusterName` | Name of your cluster | `cluster_name` | ✔
| `serviceAccount.create` | Whether a new service account should be created | `true` |
| `serviceAccount.name` | Service account to be used | |
| `hostNetwork` | Allow to use the network namespace and network resources of the node | `false` |
| `nodeSelector` | Node labels for pod assignment | {} |
| `tolerations` | Optional deployment tolerations | {} |
| `annotations` | Optional pod annotations | {} |
| `serviceAccount.create` | Whether a new service account should be created | `true` |
| `serviceAccount.name` | Service account to be used | |
| `priorityClassName` | Name of Priority Class to assign pods | system-node-critical |
| `hostNetwork` | Allow to use the network namespace and network resources of the node | `false` |
| `nodeSelector` | Node labels for pod assignment | {} |
| `tolerations` | Optional deployment tolerations | {} |
| `annotations` | Optional pod annotations | {} |
| `containerdSockPath` | Path to containerd' socket | /run/containerd/containerd.sock
3 changes: 3 additions & 0 deletions stable/aws-cloudwatch-metrics/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ spec:
{{- include "aws-cloudwatch-metrics.selectorLabels" . | nindent 8 }}
spec:
serviceAccountName: {{ include "aws-cloudwatch-metrics.serviceAccountName" . }}
{{- if .Values.priorityClassName }}
priorityClassName: {{ .Values.priorityClassName }}
{{- end }}
hostNetwork: {{ .Values.hostNetwork }}
containers:
- name: {{ .Chart.Name }}
Expand Down
4 changes: 3 additions & 1 deletion stable/aws-cloudwatch-metrics/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ serviceAccount:
create: true
name:

priorityClassName: system-node-critical

hostNetwork: false

nodeSelector: {}
Expand All @@ -26,5 +28,5 @@ tolerations: []
affinity: {}

# For bottlerocket OS (https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/ContainerInsights-troubleshooting.html#ContainerInsights-troubleshooting-bottlerocket)
# containerdSockPath: /run/dockershim.sock
# containerdSockPath: /run/dockershim.sock
containerdSockPath: /run/containerd/containerd.sock