Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets base image builds to push to private ecr #448

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Dec 20, 2022

Issue #, if available:

Description of changes:

This changes the distro-base images to push the the private ecr repos instead directly to public during postsubmits and periodics. These private ecr repos are still open to the world (any logged in aws user) for reading, but to ensure we have a check point before updating the tags in public ecr, specifically the "latest" tags, which people may be relying on, we want to push to private first.

The eks-distro-base-tag-files-update-postsubmit job will now use skopeo to mirror the images based on the tags in the EKS_DISTRO_TAG_FILE.yaml to the public ecr repos before opening the PRs in the other repos bumping their respective tag files.

/hold

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markapruett
Copy link
Member

Awaiting ecr creation before this PR is merged.

@eks-distro-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jaxesn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants