Add annotation to configure healthcheck retries for EtcdadmCluster #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-gaston
reviewed
Aug 29, 2023
abhinavmpandey08
force-pushed
the
disable-healthcheck
branch
2 times, most recently
from
ed98732 to
cf83ac8
Compare
abhinavmpandey08
changed the title
abhinavmpandey08
force-pushed
the
disable-healthcheck
branch
2 times, most recently
from
b01352e to
a275909
Compare
ahreehong
reviewed
Sep 6, 2023
abhinavmpandey08
force-pushed
the
disable-healthcheck
branch
4 times, most recently
from
c7a2b6d to
2067bbe
Compare
abhinavmpandey08
force-pushed
the
disable-healthcheck
branch
from
2067bbe to
c6f74f1
Compare
ahreehong
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds an annotation
etcdcluster.cluster.x-k8s.io/healthcheck-retrieswhich allows you to configure healthcheck tries for individualEtcdadmClusterobjects.Setting the healthcheck retries to 0 skips healthchecks for that cluster altogether and doesn't reconcile any unhealthy etcd machines.
It also makes the healthcheck interval configurable using the
--healthcheck-intervalflag on theetcdadm-controller, with the same default of 30 seconds.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.