rm(flag): remove bottles being un-needed #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This blocks creation of bottles if not removed.
|
@thesriram Will this affect anything (installations, etc) when we remove it? I am wondering if there is a case in which, removing this would cause |
|
@jfuss it wouldn't, I did a local check by manually modyfying the tap formula and it works as expected. |
jfuss
approved these changes
May 1, 2019
|
Will this work with LinuxBrew as well? |
|
@sanathkr Yes, this should work on linuxbrew as well. I tested it on a linuxbrew docker container with this change made to the formula. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.