Skip to content

Commit

Permalink
feat: TypeScript 5.5 (#1778)
Browse files Browse the repository at this point in the history
Upgrade to TypeScript 5.5.

Closes #1769 

---

Due to the newly introduced [JSDoc @import
Tag](https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#the-jsdoc-import-tag)
feature, the signature for `analyzeImportDeclaration` has changed to
accept both an `ImportDeclaration` and a `JSDocImportTag` which are
compatible enough for the purpose of this function.

Existing tests are covering the code paths that call
`analyzeImportDeclaration`.
None of the code paths currently call `analyzeImportDeclaration` with a
`JSDocImportTag`, but I opted for this change instead of a guard to
future proof any calls. The other option would have been to guard each
of the calls, however that would impose additional knowledge on the
calling site that seemed unnecessary to dangerous to me.

Adds tests for the new jsdoc-import-tag feature, though they are
currently not treated any differently than other comments. In rosetta,
comments are mostly presumed to be pre-processed by jsii and in the
structured assembly.

Also added 3 translation test cases that were previously just missing.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

---------

Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
  • Loading branch information
mikewrighton and mrgrain authored Aug 23, 2024
1 parent 598ee5c commit 510ae36
Show file tree
Hide file tree
Showing 27 changed files with 436 additions and 39 deletions.
3 changes: 2 additions & 1 deletion .backportrc.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .gitattributes

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

59 changes: 59 additions & 0 deletions .github/workflows/auto-tag-dev-v5.4.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/auto-tag-dev.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

59 changes: 59 additions & 0 deletions .github/workflows/auto-tag-releases-v5.4.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/auto-tag-releases.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

93 changes: 93 additions & 0 deletions .github/workflows/upgrade-jsii-maintenance-v5.4.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

97 changes: 97 additions & 0 deletions .github/workflows/upgrade-maintenance-v5.4.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 510ae36

Please sign in to comment.