fix: export transliterateAssembly and fix bug with transliterate cli #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is already used in other tools and should be available as programmatic API. Both `--loose` and `--language` were using the `-l` alias, causing the language option to be booleans instead of strings.
mrgrain
commented
Jun 13, 2023
| return target; | ||
| }) | ||
| ? args.language | ||
| .map((lang) => lang.toUpperCase()) |
There was a problem hiding this comment.
Throwing this in for a slightly better UX
rix0rrr
approved these changes
Jun 14, 2023
This was referenced Jul 3, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
…(backport) (#161) Backport of #121 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
mergify bot
pushed a commit
to aws/jsii
that referenced
this pull request
Jul 3, 2023
…(backport) (#4166) Backport of aws/jsii-rosetta#121 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is already used in other tools and should be available as programmatic API.
Both
--looseand--languagewere using the-lalias, causing the language option to be booleans instead of strings.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.