chore: fix ci PRs might get merged with failing tests #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Jul 29, 2024
aws-cdk-automation
deleted the
mrgrain/ci/fix-unit-tests-can-be-skipped-when-failing
branch
aws-cdk-automation
pushed a commit
that referenced
this pull request
Jul 29, 2024
We had a PR aws/jsii-compiler#1191 that got merged despite a failure in Node22 tests. This happened because on a failure of one of the matrix builds, the job that is unifying them is skipped. This is documented behavior:  The fix is to make sure the combination step always runs and manually check the status of the matrix build. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit eff4ad9)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
#1690) # Backport This will backport the following commits from `main` to `maintenance/v5.3`: - [chore: fix ci PRs might get merged with failing tests (#1689)](#1689) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a PR aws/jsii-compiler#1191 that got merged despite a failure in Node22 tests.
This happened because on a failure of one of the matrix builds, the job that is unifying them is skipped. This is documented behavior:
The fix is to make sure the combination step always runs and manually check the status of the matrix build.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.