fix(jsii-reflect): getAncestors takes a long time

Memoize the call so repeated calls are faster.
aws · Nov 7, 2023 · 0073c3e · 0073c3e
1 parent 90ce1da
commit 0073c3e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/packages/jsii-reflect/lib/class.ts b/packages/jsii-reflect/lib/class.ts
@@ -1,5 +1,6 @@
 import * as jsii from '@jsii/spec';
 
+import { memoized } from './_memoized';
 import { Assembly } from './assembly';
 import { Initializer } from './initializer';
 import { InterfaceType } from './interface';
@@ -20,6 +21,7 @@ export class ClassType extends ReferenceType {
   /**
    * Base class (optional).
    */
+  @memoized
   public get base(): ClassType | undefined {
     if (!this.spec.base) {
       return undefined;
@@ -60,12 +62,22 @@ export class ClassType extends ReferenceType {
 
   /**
    * Returns list of all base classes (first is the direct base and last is the top-most).
+   *
+   * @deprecated use ClassType.ancestors instead
    */
   public getAncestors() {
+    return this.ancestors;
+  }
+
+  /**
+   * Returns list of all base classes (first is the direct base and last is the top-most).
+   */
+  @memoized
+  public get ancestors() {
     const out = new Array<ClassType>();
     if (this.base) {
       out.push(this.base);
-      out.push(...this.base.getAncestors());
+      out.push(...this.base.ancestors);
     }
     return out;
   }

diff --git a/packages/jsii-reflect/lib/method.ts b/packages/jsii-reflect/lib/method.ts
@@ -1,5 +1,6 @@
 import * as jsii from '@jsii/spec';
 
+import { memoized } from './_memoized';
 import { Assembly } from './assembly';
 import { Callable } from './callable';
 import { Documentable } from './docs';
@@ -42,6 +43,7 @@ export class Method
     return this.spec.name;
   }
 
+  @memoized
   public get overrides(): Type | undefined {
     if (!this.spec.overrides) {
       return undefined;

diff --git a/packages/jsii-reflect/lib/type.ts b/packages/jsii-reflect/lib/type.ts
@@ -124,7 +124,7 @@ export abstract class Type implements Documentable, SourceLocatable {
       return this.getInterfaces(true).some((iface) => iface === base);
     }
     if (this.isClassType() && base.isClassType()) {
-      return this.getAncestors().some((clazz) => clazz === base);
+      return this.ancestors.some((clazz) => clazz === base);
     }
     return false;
   }