-
Notifications
You must be signed in to change notification settings - Fork 245
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(pacmak): don't automatically translate examples without asking (#…
…3219) Given the current state of example tooling, the existing default was a bad choice. It forces everyone who is publishing jsii packages everywhere to spend CPU cycles to do example parsing and translation which is bound to fail anyway (as the fixtures and compilation directory will probably not be set up for success, and translation must proceed in a single-threaded fashion). The new default is to use translations if they exist, and otherwise don't do translations. * Builds that care (i.e., mostly the CDK build), will be using `rosetta extract` already to be efficient and correct about compilation, and the tablet files will be picked up as usual. * Builds that don't care will get more efficient. BREAKING CHANGES: Pacmak no longer tries to translate examples by default: this feature is now opt-in. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
- Loading branch information
Showing
2 changed files
with
19 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters