feat: add unit test

packages/@jsii/kernel/lib/api.ts

@@ -101,16 +101,16 @@ export interface LoadResponse {
 }
 
 export interface InvokeScriptRequest {
-  readonly pkgname: string;
+  readonly assembly: string;
   readonly script: string;
-  readonly args?: any[];
+  readonly args?: string[];
 }
 
 export interface InvokeScriptResponse {
   readonly status: number | null;
-  readonly stdout: string;
-  readonly stderr: string;
-  readonly output: string[];
+  readonly stdout: Buffer;
+  readonly stderr: Buffer;
+  readonly signal: string | null;
 }
 
 export interface CreateRequest {

packages/@jsii/kernel/lib/kernel.ts

@@ -139,17 +139,40 @@ export class Kernel {
   public invokeBinScript(
     req: api.InvokeScriptRequest,
   ): api.InvokeScriptResponse {
-    const result = cp.spawnSync(
-      path.join(this._getPackageDir(req.pkgname), req.script),
-      req.args,
-    );
+    const packageDir = this._getPackageDir(req.assembly);
+    if (fs.pathExistsSync(packageDir)) {
+      // module exists, verify version
+      const epkg = fs.readJsonSync(path.join(packageDir, 'package.json'));
 
-    return {
-      output: result.output,
-      stdout: result.stdout,
-      stderr: result.stderr,
-      status: result.status,
-    };
+      if (!epkg.bin) {
+        throw new Error('There is no bin scripts defined for this package.');
+      }
+
+      const scriptPath = epkg.bin[req.script];
+
+      if (!epkg.bin) {
+        throw new Error(`Script with name ${req.script} was not defined.`);
+      }
+
+      const result = cp.spawnSync(
+        process.execPath,
+        [
+          ...process.execArgv,
+          '--',
+          path.join(packageDir, scriptPath),
+          ...(req.args ?? []),
+        ],
+        { encoding: 'utf-8' },
+      );
+
+      return {
+        stdout: result.stdout,
+        stderr: result.stderr,
+        status: result.status,
+        signal: result.signal,
+      };
+    }
+    throw new Error(`Package with name ${req.assembly} was not loaded.`);
   }
 
   public create(req: api.CreateRequest): api.CreateResponse {

packages/@jsii/kernel/test/kernel.test.ts

@@ -2133,6 +2133,15 @@ defineTest('Override transitive property', (sandbox) => {
   expect(propValue).toBe('N3W');
 });
 
+defineTest('invokeBinScript() return output', (sandbox) => {
+  const result = sandbox.invokeBinScript({
+    assembly: 'jsii-calc',
+    script: 'calc',
+  });
+
+  expect(result.stdout).toEqual('Hello World!\n');
+});
+
 // =================================================================================================
 
 const testNames: { [name: string]: boolean } = {};

packages/@jsii/python-runtime/tests/test_compliance.py

@@ -85,6 +85,7 @@
 from scope.jsii_calc_lib import IFriendly, EnumFromScopedModule, Number
 from scope.jsii_calc_lib.custom_submodule_name import IReflectable, ReflectableEntry
 
+from subprocess import Popen, PIPE, STDOUT
 
 # Note: The names of these test functions have been chosen to map as closely to the
 #       Java Compliance tests as possible.

packages/jsii-calc/bin/calc

@@ -0,0 +1,2 @@
+#!/usr/bin/env node
+require('./calc.js');

packages/jsii-calc/bin/calc.ts

@@ -0,0 +1,5 @@
+#!/usr/bin/env node
+
+/* eslint-disable no-console */
+
+console.info('Hello World!');

packages/jsii-calc/package.json

@@ -14,6 +14,9 @@
   "bugs": {
     "url": "https://github.com/aws/jsii/issues"
   },
+  "bin": {
+    "calc": "bin/calc"
+  },
   "repository": {
     "type": "git",
     "url": "https://github.com/aws/jsii.git",

packages/jsii-calc/test/assembly.jsii

@@ -7,6 +7,9 @@
     ],
     "url": "https://aws.amazon.com"
   },
+  "bin": {
+    "calc": "bin/calc"
+  },
   "bundled": {
     "@fixtures/jsii-calc-bundled": "^0.19.0"
   },
@@ -14229,5 +14232,5 @@
     }
   },
   "version": "0.0.0",
-  "fingerprint": "azqNkkl+/4FLzTVBLkOyHcokS4xLoYtHsri0z9kIehQ="
+  "fingerprint": "QHc8YZS13IljwCQpg6AZlBxIZvkAbfnCFh6Vi+e0Cgg="
 }

packages/jsii-pacmak/lib/targets/python.ts

@@ -1485,7 +1485,7 @@ class PythonModule implements PythonType {
     const scripts: string[] = [];
     if (this.loadAssembly) {
       if (this.assembly.bin != null) {
-        for (const [name, script_path] of Object.entries(this.assembly.bin)) {
+        for (const name of Object.keys(this.assembly.bin)) {
           const script_file = path.join(
             'src',
             pythonModuleNameToFilename(this.pythonName),
@@ -1515,7 +1515,7 @@ class PythonModule implements PythonType {
             '__jsii_assembly__.invokeBinScript(',
             [
               JSON.stringify(this.assembly.name),
-              JSON.stringify(script_path),
+              JSON.stringify(name),
               'sys.argv[1:]',
             ],
             ')',
@@ -1695,11 +1695,7 @@ class Package {
       mod.emit(code, context);
       code.closeFile(filename);
 
-      for (const script of mod.emitBinScripts(code)) {
-        if (scripts.indexOf(script) < 0) {
-          scripts.push(script);
-        }
-      }
+      Array.prototype.push.apply(scripts, mod.emitBinScripts(code));
     }
 
     // Handle our package data.

packages/jsii/lib/assembler.ts

@@ -200,8 +200,8 @@ export class Assembler implements Emitter {
       docs,
       readme,
       jsiiVersion,
-      fingerprint: '<TBD>',
       bin: this.projectInfo.bin,
+      fingerprint: '<TBD>',
     };
 
     const validator = new Validator(this.projectInfo, assembly);