Implementing an interface from Java does not work #1003
Labels
bug
This issue is a bug.
Comments
|
The interface implementation needs to inherit from Additionally, the constructor should look like: public MyMachineImage() {
super(InitializationMode.JSII);
JsiiEngine.getInstance().createNewObject(this);
}However even when adding this, it does not work (and it registers a number of overrides it shouldn't be registering). There appears to be a bug in that interface discovery is not performed at all here... |
|
Actually - scratch the previous comment about having to descend from |
|
Also it looks this bug can only trigger because of the presence of another bug (which has already been fixed, but is yet to release). |
RomainMuller
added a commit
that referenced
this issue
Nov 19, 2019
When moving out of callbacks, the result was not turned into a reference before being passed out to the jsii kernel, causing TypeErrors when attempting to turn structs (and probably other non-primitive types) to JSON. Discovered while attempting to reproduce #1003, which can no longer trigger as it depended on returning a Struct through and `any` and being hit with the bug fixed in #997... the fix also removed the conditions that make leveraging the cause possible (or at the very least I could not come up with a reproduction, and have verified that the original bug report no longer reproduces once #997 is in). That being said, still introduced the necessary changes to address the cause by properly discovering interfaces and adding the relevant overrides filtering, as this may improve the performance and reliability of the jsii runtime for Java. Fixes #1003
RomainMuller
added a commit
that referenced
this issue
Nov 19, 2019
When moving out of callbacks, the result was not turned into a reference before being passed out to the jsii kernel, causing TypeErrors when attempting to turn structs (and probably other non-primitive types) to JSON. Discovered while attempting to reproduce #1003, which can no longer trigger as it depended on returning a Struct through and `any` and being hit with the bug fixed in #997... the fix also removed the conditions that make leveraging the cause possible (or at the very least I could not come up with a reproduction, and have verified that the original bug report no longer reproduces once #997 is in). That being said, still introduced the necessary changes to address the cause by properly discovering interfaces and adding the relevant overrides filtering, as this may improve the performance and reliability of the jsii runtime for Java. Fixes #1003
|
Confirming this is fixed in |
mergify bot
pushed a commit
that referenced
this issue
Nov 28, 2019
* fix(python): correctly handle structs out of callbacks When moving out of callbacks, the result was not turned into a reference before being passed out to the jsii kernel, causing TypeErrors when attempting to turn structs (and probably other non-primitive types) to JSON. Discovered while attempting to reproduce #1003, which can no longer trigger as it depended on returning a Struct through and `any` and being hit with the bug fixed in #997... the fix also removed the conditions that make leveraging the cause possible (or at the very least I could not come up with a reproduction, and have verified that the original bug report no longer reproduces once #997 is in). That being said, still introduced the necessary changes to address the cause by properly discovering interfaces and adding the relevant overrides filtering, as this may improve the performance and reliability of the jsii runtime for Java. Fixes #1003 * improve documentation & test coverage * fixup * inline-fy doc * remove spurious 'final' * Add missing fget * add type annotation to make MyPy happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
Affected Languages
TypeScriptorJavascriptPythonJavaC#,F#, ...)General Information
0.20.6What is the problem?
Full repro: https://github.com/rix0rrr/jsii-test-drive/tree/master/java/implement-interface
Verbose Log
The text was updated successfully, but these errors were encountered: