Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsii 1.0.0 fails aws-cdk build #1285

Closed
eladb opened this issue Feb 23, 2020 · 1 comment · Fixed by #1287
Closed

jsii 1.0.0 fails aws-cdk build #1285

eladb opened this issue Feb 23, 2020 · 1 comment · Fixed by #1287
Assignees
@RomainMuller
Labels
bug This issue is a bug. in-progress Issue is being actively worked on. p1

Comments

@eladb
Copy link
Contributor

eladb commented Feb 23, 2020 •
edited by RomainMuller
Loading

🐛 Bug Report

When upgrading the CDK to use jsii 1.0.0, the build is failing.

See aws/aws-cdk#6407
@eladb eladb added the bug This issue is a bug. label Feb 23, 2020
@RomainMuller
Copy link
Contributor

This seems caused by missing code generation of nullable markers in certain interface implementation scenarios (possibly generated proxies for interfaces / structs). I'm looking into this.

RomainMuller added a commit that referenced this issue Feb 24, 2020
@RomainMuller
fix(dotnet): missing ? on nullable interface members
658d2be 
When interfaces declare nullable members, the code generator erroneously omitted the `?` that denotes it, while generated implementations of the interface would have it, causing compilation failures.

Fixes #1285
@RomainMuller RomainMuller mentioned this issue Feb 24, 2020
Merged
@SomayaB SomayaB added the in-progress Issue is being actively worked on. label Feb 24, 2020
@mergify mergify bot closed this as completed in #1287 Feb 25, 2020
mergify bot added a commit that referenced this issue Feb 25, 2020
@RomainMuller @mergify
fix(dotnet): missing ? on nullable interface members (#1287)
9299db2 
* fix(dotnet): missing ? on nullable interface members

When interfaces declare nullable members, the code generator erroneously omitted the `?` that denotes it, while generated implementations of the interface would have it, causing compilation failures.

Fixes #1285

* Fixup test expectations in jsii-reflect

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. in-progress Issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dotnet): missing ? on nullable interface members aws/jsii
3 participants
@RomainMuller @eladb @SomayaB