Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSII seems to not prevent a read-write property from being downgraded to read-only #199

Closed
RomainMuller opened this issue Aug 25, 2018 · 3 comments

Comments

@RomainMuller
Copy link
Contributor

@moofish32 suffered an occurrence in aws/aws-cdk#538 where jsii did not correctly capture that a read-write property was being incorrectly implemented as readonly, causing the Java bindings to fail building due to a missing implementation of the setter (property was inherited from an interface).

@moofish32
Copy link

moofish32 commented Aug 25, 2018

reproduction - https://github.com/moofish32/jsii-bug-repros (currently just on master)

I'm not sure if this isn't an issue in Typescript?

@RomainMuller
Copy link
Contributor Author

I have already confirmed that the issue would not be present in the re-write in #188. I have added a test demonstrating that.

@RomainMuller
Copy link
Contributor Author

I have also added a fix on the current implementation of jsii (#201).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants