-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSII seems to not prevent a read-write property from being downgraded to read-only #199
Comments
reproduction - https://github.com/moofish32/jsii-bug-repros (currently just on master) I'm not sure if this isn't an issue in Typescript? |
I have already confirmed that the issue would not be present in the re-write in #188. I have added a test demonstrating that. |
RomainMuller
pushed a commit
that referenced
this issue
Aug 25, 2018
I have also added a fix on the current implementation of |
RomainMuller
added a commit
that referenced
this issue
Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@moofish32 suffered an occurrence in aws/aws-cdk#538 where
jsii
did not correctly capture that a read-write property was being incorrectly implemented asreadonly
, causing the Java bindings to fail building due to a missing implementation of the setter (property was inherited from an interface).The text was updated successfully, but these errors were encountered: