Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Runtime Get/Set #2128

Closed
4 tasks done
MrArnoldPalmer opened this issue Oct 14, 2020 · 2 comments · Fixed by #2178
Closed
4 tasks done

Go Runtime Get/Set #2128

MrArnoldPalmer opened this issue Oct 14, 2020 · 2 comments · Fixed by #2178
Assignees
@SoManyHs
Labels
feature-request A feature should be added or improved. language/go Regarding GoLang bindings
Milestone
GoLang Alpha

Comments

@MrArnoldPalmer
Copy link
Contributor

MrArnoldPalmer commented Oct 14, 2020 •
edited by SoManyHs
Loading

Go runtime support for JSII get/set calls. Update jsii-pacmak implementations of interface methods for property access to call these runtime fns.

  • GetRequest
  • SetRequest
  • StaticGetRequest
  • StaticSetRequest
@MrArnoldPalmer MrArnoldPalmer added language/go Regarding GoLang bindings feature-request A feature should be added or improved. labels Oct 14, 2020
@MrArnoldPalmer MrArnoldPalmer added this to the GoLang Alpha milestone Oct 14, 2020
@MrArnoldPalmer MrArnoldPalmer self-assigned this Oct 14, 2020
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Oct 14, 2020
Closed
4 tasks
@SoManyHs SoManyHs self-assigned this Oct 15, 2020
@SoManyHs
Copy link
Contributor

Note: #2133 currently has placeholder for StaticGetRequest on static properties

@SoManyHs SoManyHs mentioned this issue Oct 24, 2020
Merged
@SomayaB SomayaB added the in-progress Issue is being actively worked on. label Oct 26, 2020
@mergify mergify bot closed this as completed in #2178 Oct 26, 2020
mergify bot pushed a commit that referenced this issue Oct 26, 2020
@SoManyHs
chore(go): support get/set kernel API in go runtime (#2178)
0d81c6d 
Fixes #2128

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@SoManyHs SoManyHs removed the in-progress Issue is being actively worked on. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoManyHs SoManyHs

Labels
feature-request A feature should be added or improved. language/go Regarding GoLang bindings
Projects
None yet
Milestone
GoLang Alpha
Development

Successfully merging a pull request may close this issue.

chore(go): support get/set kernel API in go runtime SoManyHs/jsii
3 participants
@MrArnoldPalmer @SomayaB @SoManyHs