process.terminate() got an unexpected keyword argument 'timeout'

[camilobermudez85]

🐛 Bug Report

Affected Languages

• Python

General Information

• JSII Version: 1.16.0
• Platform: Debian

What is the problem?

Hey, guys. While running cdk diff on a python 3.7.6 app I'm getting the next error:

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/jsii/_kernel/providers/process.py", line 293, in stop
    self._process.wait(timeout=5)
  File "/usr/local/lib/python3.7/subprocess.py", line 1019, in wait
    return self._wait(timeout=timeout)
  File "/usr/local/lib/python3.7/subprocess.py", line 1645, in _wait
    raise TimeoutExpired(self.args, timeout)
subprocess.TimeoutExpired: Command '['node', '/usr/local/lib/python3.7/site-packages/jsii/_embedded/jsii/jsii-runtime.js']' timed out after 5 seconds

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/jsii/_kernel/providers/process.py", line 296, in stop
    self._process.terminate(timeout=5)
TypeError: terminate() got an unexpected keyword argument 'timeout'

The problem seems to be caused by this change introduced in PR #2100:

Indeed, timeout is not a valid parameter for that method, perhaps removing it should be enough to fix the issue. Thanks a lot!

@RomainMuller

[jhzab]

I'm also running into the timeout when using cdk synth.

Running under Ubuntu 20.04 on WSL1.
aws-cdk version (python modules and nodejs cli tool): 1.82.0
nodejs version: 14.15.4 (but also tried with 10.x and 12.x)
python version: 3.8.5

Steps to reproduce:

• mkdir sftest
• cd sftest
• cdk init sample-app --language=python
• Add aws-cdk.aws_stepfunctions_tasks==1.82.0 to install_requires and install dependencies (do not install the sftest package :-) )
• Add from aws_cdk import aws_stepfunctions_tasks as sfn_tasks to the stack under sftest/sftest_stack.py
• Run cdk synth
• Error will be at the top of the output

Error appears only with the import. Hope the information is helpful.

[RomainMuller]

Oh jeez. Yeah I'll get a fix out ASAP.

[RomainMuller]

This ought to be solved by release 1.17.1 of the jsii runtime library, which should be available already (pip install --upgrade jsii should do the magic)