Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): nested types are not namespaced #2650

Merged
merged 7 commits into from
Mar 12, 2021
Merged

fix(go): nested types are not namespaced #2650

merged 7 commits into from
Mar 12, 2021

Conversation

RomainMuller
Copy link
Contributor

Nested types were generated in the same package as they parent, without
any namespacing additions, meaning that if two types in the same package
have nested types with the same name, the generated code would be
invalid.

This namespaces the nested types in go by prefixing their names with
their nesting type's name, using an _ delimiter, which is the same as
what is done for static methods.

Also added a validation in the jsii compiler that prohibits that a
nested type and a static method share the same PascalCase
transformation, as this would result in conflicts in Go, but also in C#.

Fixes #2649

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller RomainMuller added bug This issue is a bug. language/go Regarding GoLang bindings module/jsii Issues affecting the `jsii` module. module/pacmak Issues affecting the `jsii-pacmak` module contribution/core This is a PR that came from AWS. labels Mar 4, 2021
@RomainMuller RomainMuller requested a review from eladb March 4, 2021 16:01
@RomainMuller RomainMuller self-assigned this Mar 4, 2021
eladb
eladb reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Let's merge that in so I can use for my bugs :-)

packages/jsii-pacmak/lib/targets/go/types/go-type.ts Outdated Show resolved Hide resolved
packages/jsii-pacmak/test/generated-code/examples.test.ts Show resolved Hide resolved
packages/jsii-pacmak/test/generated-code/examples.test.ts Outdated Show resolved Hide resolved
packages/jsii-pacmak/test/generated-code/examples/nested-types.ts
@@ -0,0 +1,31 @@
// See: https://github.com/aws/jsii/issues/2649
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if perhaps we should afford for multiple files so basically each example will be in a separate directory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update it so that - if it's a file, it's a single-file example... If it's a directory, it's a multiple-files example. I went for just what I needed at this point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we can iterate on this

packages/jsii-pacmak/test/generated-code/examples/nested-types.ts Show resolved Hide resolved
@RomainMuller RomainMuller force-pushed the rmuller/fix-nested-types branch 3 times, most recently from 0c52cf3 to 1876073 Compare March 4, 2021 16:57
@RomainMuller
fix(go): nested types are not namespaced
3505b69 
Nested types were generated in the same package as they parent, without
any namespacing additions, meaning that if two types in the same package
have nested types with the same name, the generated code would be
invalid.

This namespaces the nested types in go by prefixing their names with
their nesting type's name, using an `_` delimiter, which is the same as
what is done for static methods.

Also added a validation in the `jsii` compiler that prohibits that a
nested type and a static method share the same PascalCase
transformation, as this would result in conflicts in Go, but also in C#.

Fixes #2649
@RomainMuller RomainMuller marked this pull request as ready for review March 4, 2021 17:06
@RomainMuller RomainMuller requested a review from eladb March 5, 2021 08:58
RomainMuller added a commit that referenced this pull request Mar 5, 2021
@RomainMuller
fix(python): duplicated kwargs when field is multi-inherited
2fc879f 
When a struct field is inherited from more than one parent (this could
be twice from the same type - in the case of a diamond shape; or from
two distinct parents that declare the same field), the lifted keyword
arguments in python would be duplicated for this field.

This is because the method that performs the keyword argument lifting
did not perform name-based de-duplication, and operates directly on the
"raw" assembly (whereby it must traverse the inheritance tree itself,
as opposed to the Go generator which uses `jsii-reflect` and has the
field collection done by that library).

Added the necessary de-duplication logic and confirmed the produced code
now looks correct using the exact same test harness as I had introduced
in #2650.

Fixes #2653
RomainMuller added a commit that referenced this pull request Mar 5, 2021
@RomainMuller
fix(python): duplicated kwargs when field is multi-inherited
3753772 
When a struct field is inherited from more than one parent (this could
be twice from the same type - in the case of a diamond shape; or from
two distinct parents that declare the same field), the lifted keyword
arguments in python would be duplicated for this field.

This is because the method that performs the keyword argument lifting
did not perform name-based de-duplication, and operates directly on the
"raw" assembly (whereby it must traverse the inheritance tree itself,
as opposed to the Go generator which uses `jsii-reflect` and has the
field collection done by that library).

Added the necessary de-duplication logic and confirmed the produced code
now looks correct using the exact same test harness as I had introduced
in #2650.

Fixes #2653
@RomainMuller RomainMuller mentioned this pull request Mar 5, 2021
Merged
eladb
eladb approved these changes Mar 7, 2021
View reviewed changes
packages/jsii-pacmak/test/generated-code/examples/nested-types.ts
@@ -0,0 +1,31 @@
// See: https://github.com/aws/jsii/issues/2649
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we can iterate on this

RomainMuller and others added 2 commits March 12, 2021 09:52
@RomainMuller RomainMuller force-pushed the rmuller/fix-nested-types branch 2 times, most recently from 3f0a6ad to a0d9c13 Compare March 12, 2021 15:57
@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
mergify bot referenced this pull request in projen/projen Mar 17, 2021
@dependabot
chore(deps-dev): Bump jsii-pacmak from 1.24.0 to 1.25.0 (#621)
1ad4883 
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

If you make any changes to it yourself then they will take precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [jsii-pacmak](https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak) from 1.24.0 to 1.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-pacmak's releases</a>.</em></p>
<blockquote>
<h2>v1.25.0</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-pacmak's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976"><code>2dbe84d</code></a> fix(go): invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2704">#2704</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2696">#2696</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df"><code>52bd510</code></a> fix(go): duplicate conversion functions when parent structs have the same bas...</li>
<li><a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193"><code>c9a36a6</code></a> fix(go): missing imports required by collection types (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2691">#2691</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a"><code>daca06f</code></a> fix(go): missing imports needed by base members (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2685">#2685</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03"><code>9562108</code></a> feat(go): packageName and versionSuffix (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2687">#2687</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2650">#2650</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2674">#2674</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/d6140ce2e7b94984f7042a920f550b3b0ac22f8d"><code>d6140ce</code></a> chore(go): make Load call idempotent (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2645">#2645</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2644">#2644</a>)</li>
<li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-pacmak">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jsii-pacmak&package-manager=npm_and_yarn&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually


</details>
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
mergify bot referenced this pull request in cdktf/cdktf-provider-github Mar 17, 2021
@dependabot
chore(deps-dev): bump jsii-diff from 1.24.0 to 1.25.0 (#260)
5a14ba7 
Bumps [jsii-diff](https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff) from 1.24.0 to 1.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-diff's releases</a>.</em></p>
<blockquote>
<h2>v1.25.0</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-diff's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff/issues/2696">#2696</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff/issues/2674">#2674</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-diff/issues/2644">#2644</a>)</li>
<li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-diff">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jsii-diff&package-manager=npm_and_yarn&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually


</details>
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
mergify bot referenced this pull request in cdktf/cdktf-provider-github Mar 17, 2021
@dependabot
chore(deps-dev): bump jsii-pacmak from 1.24.0 to 1.25.0 (#261)
77ad283 
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

If you make any changes to it yourself then they will take precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [jsii-pacmak](https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak) from 1.24.0 to 1.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-pacmak's releases</a>.</em></p>
<blockquote>
<h2>v1.25.0</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-pacmak's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976"><code>2dbe84d</code></a> fix(go): invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2704">#2704</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2696">#2696</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df"><code>52bd510</code></a> fix(go): duplicate conversion functions when parent structs have the same bas...</li>
<li><a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193"><code>c9a36a6</code></a> fix(go): missing imports required by collection types (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2691">#2691</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a"><code>daca06f</code></a> fix(go): missing imports needed by base members (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2685">#2685</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03"><code>9562108</code></a> feat(go): packageName and versionSuffix (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2687">#2687</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2650">#2650</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2674">#2674</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/d6140ce2e7b94984f7042a920f550b3b0ac22f8d"><code>d6140ce</code></a> chore(go): make Load call idempotent (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2645">#2645</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-pacmak/issues/2644">#2644</a>)</li>
<li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-pacmak">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jsii-pacmak&package-manager=npm_and_yarn&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually


</details>
mergify bot referenced this pull request in cdktf/cdktf-provider-github Mar 17, 2021
@dependabot
chore(deps-dev): bump jsii from 1.24.0 to 1.25.0 (#262)
0c64e35 
Bumps [jsii](https://github.com/aws/jsii/tree/HEAD/packages/jsii) from 1.24.0 to 1.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii's releases</a>.</em></p>
<blockquote>
<h2>v1.25.0</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2696">#2696</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2650">#2650</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2674">#2674</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii/issues/2644">#2644</a>)</li>
<li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jsii&package-manager=npm_and_yarn&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually


</details>
This was referenced Mar 17, 2021
Merged
Merged
mergify bot referenced this pull request in cdklabs/jsii-docgen Mar 17, 2021
@dependabot
chore(deps): bump jsii-reflect from 1.24.0 to 1.25.0 (#278)
f03d14d 
Bumps [jsii-reflect](https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect) from 1.24.0 to 1.25.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/releases">jsii-reflect's releases</a>.</em></p>
<blockquote>
<h2>v1.25.0</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/jsii/blob/v1.25.0/CHANGELOG.md">jsii-reflect's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/aws/jsii/compare/v1.24.0...v1.25.0">1.25.0</a> (2021-03-16)</h2>
<h3>Features</h3>
<ul>
<li><strong>compliance:</strong> Compliance suite (<a href="https://github.com/aws/jsii/issues/2607">#2607</a>) (<a href="https://github.com/aws/jsii/commit/18b2c167bbc47d7620e6a952e08751af28bf53a6">18b2c16</a>)</li>
<li><strong>go:</strong> packageName and versionSuffix (<a href="https://github.com/aws/jsii/issues/2687">#2687</a>) (<a href="https://github.com/aws/jsii/commit/95621082cb742bb8dc24e28f3bf6cb6013050c03">9562108</a>), closes <a href="https://github.com/aws/jsii/issues/2632">#2632</a></li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li><strong>go:</strong> duplicate conversion functions when parent structs have the same base name (<a href="https://github.com/aws/jsii/issues/2697">#2697</a>) (<a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df">52bd510</a>), closes <a href="https://github.com/aws/jsii/issues/2692">#2692</a></li>
<li><strong>go:</strong> invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/issues/2704">#2704</a>) (<a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976">2dbe84d</a>), closes <a href="https://github.com/aws/jsii/issues/2622">#2622</a> <a href="https://github.com/aws/jsii/issues/2617">#2617</a></li>
<li><strong>go:</strong> missing imports needed by base members (<a href="https://github.com/aws/jsii/issues/2685">#2685</a>) (<a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a">daca06f</a>), closes <a href="https://github.com/aws/jsii/issues/2647">#2647</a></li>
<li><strong>go:</strong> missing imports required by collection types (<a href="https://github.com/aws/jsii/issues/2691">#2691</a>) (<a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193">c9a36a6</a>), closes <a href="https://github.com/aws/jsii/issues/2689">#2689</a></li>
<li><strong>go:</strong> nested types are not namespaced (<a href="https://github.com/aws/jsii/issues/2650">#2650</a>) (<a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb">45b527c</a>), closes <a href="https://github.com/aws/jsii/issues/2649">#2649</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/jsii/commit/2dbe84dfeff8d6f63aab19c1674fb7c9d17ea976"><code>2dbe84d</code></a> fix(go): invalid code when a module only has static methods [test only] (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2704">#2704</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/70bcd56d7d703e4306285ffcd16080f43eaf3cc1"><code>70bcd56</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2696">#2696</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/52bd510a994597cc166effde0b8c658a2a8cb0df"><code>52bd510</code></a> fix(go): duplicate conversion functions when parent structs have the same bas...</li>
<li><a href="https://github.com/aws/jsii/commit/c9a36a6c0e18c44aa8e8e7e719cb9df144da5193"><code>c9a36a6</code></a> fix(go): missing imports required by collection types (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2691">#2691</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/daca06f7c426d1fba509068ab842bd8dc7ddb62a"><code>daca06f</code></a> fix(go): missing imports needed by base members (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2685">#2685</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/45b527c0b2f35a09b715c1a6c5940ec0578007fb"><code>45b527c</code></a> fix(go): nested types are not namespaced (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2650">#2650</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/7006e11f3e70b93d5fc80380b9b2fc4517e2a666"><code>7006e11</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2674">#2674</a>)</li>
<li><a href="https://github.com/aws/jsii/commit/188336275e5d48bfc47c6d43295ede1ee7c7a14d"><code>1883362</code></a> chore: npm-check-updates &amp;&amp; yarn upgrade (<a href="https://github.com/aws/jsii/tree/HEAD/packages/jsii-reflect/issues/2644">#2644</a>)</li>
<li>See full diff in <a href="https://github.com/aws/jsii/commits/v1.25.0/packages/jsii-reflect">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=jsii-reflect&package-manager=npm_and_yarn&previous-version=1.24.0&new-version=1.25.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually


</details>
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. language/go Regarding GoLang bindings module/jsii Issues affecting the `jsii` module. module/pacmak Issues affecting the `jsii-pacmak` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go: namespaces with the same name as a class are broken
2 participants
@RomainMuller @eladb