Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): nested types are not namespaced #2650

Merged
merged 7 commits into from
Mar 12, 2021
Merged

Commits on Mar 4, 2021

  1. fix(go): nested types are not namespaced

    Nested types were generated in the same package as they parent, without
    any namespacing additions, meaning that if two types in the same package
    have nested types with the same name, the generated code would be
    invalid.
    
    This namespaces the nested types in go by prefixing their names with
    their nesting type's name, using an `_` delimiter, which is the same as
    what is done for static methods.
    
    Also added a validation in the `jsii` compiler that prohibits that a
    nested type and a static method share the same PascalCase
    transformation, as this would result in conflicts in Go, but also in C#.
    
    Fixes #2649
    RomainMuller committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    3505b69 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Configuration menu
    Copy the full SHA
    8f01787 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b2673c View commit details
    Browse the repository at this point in the history
  3. Update tsconfig.json

    RomainMuller authored Mar 5, 2021
    Configuration menu
    Copy the full SHA
    136038a View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Update packages/jsii-pacmak/lib/targets/go/types/go-type.ts

    Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
    RomainMuller and Elad Ben-Israel authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    3f344a3 View commit details
    Browse the repository at this point in the history
  2. Update examples.test.ts

    RomainMuller authored Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2504ec0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0ed87bc View commit details
    Browse the repository at this point in the history