go: dates are mistreated as strings

[iliapolo]

🐛 Bug Report

Golang generated code results in Date arguments treated as plain strings.

Affected Languages

• TypeScript or Javascript
• Python
• Java
• .NET (C#, F#, ...)
• Golang

General Information

• JSII Version: ALL
• Platform: ALL

What is the problem?

Consider the following TS code:

jsii/packages/jsii-calc/lib/compliance.ts

Lines 118 to 124 in 1883362

	public set dateProperty(value: Date) {
	// https://stackoverflow.com/a/643827/737957
	if (Object.prototype.toString.call(value) !== '[object Date]') {
	throw new Error(`not a date: ${value as any} type=${typeof value}`);
	}
	this.dateValue = value;

The resulting Golang code would be:

func (a *allTypes_jsiiProxy) SetDateProperty(val string) {
	_jsii_.Set(
		a,
		"dateProperty",
		val,
	)
}

Which causes a deserialization error:

test panicked: "Expected Date, got \"12345\""

Stemmed from here:

jsii/packages/@jsii/kernel/lib/serialization.ts

Lines 153 to 155 in 1883362

	if (!isWireDate(value)) {
	throw new Error(`Expected Date, got ${JSON.stringify(value)}`);
	}

This seems to be a known issue, as evident here:

jsii/packages/jsii-pacmak/lib/targets/go/types/go-type-reference.ts

Lines 15 to 16 in 1883362

	// TODO: Resolve "time" package dependency where needed and change to "time.Time"
	date: 'string',

Verbose Log

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.