Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pacmak): a "dev" version of jsii-pacmak can not pack Java #3107

Closed
rix0rrr opened this issue Nov 1, 2021 · 1 comment · Fixed by #3121
Closed

(pacmak): a "dev" version of jsii-pacmak can not pack Java #3107

rix0rrr opened this issue Nov 1, 2021 · 1 comment · Fixed by #3121
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 1, 2021

🐛 Bug Report

Repo-compiled versions of jsii-pacmak and related tools always have version 0.0.0.

When a repo-compiled version of jsii-pacmak is used to build Java packages, it writes the following dependency version for jsii-runtime: <version>(, 0.0.1)</version>.

Afterwards Maven is very angry and doesn't want to play with us anymore.
@rix0rrr rix0rrr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2021
@rix0rrr rix0rrr changed the title (pacmak): a "dev" version of jsii-pacmak can no longer pack Java (pacmak): a "dev" version of jsii-pacmak can not pack Java Nov 1, 2021
@rix0rrr rix0rrr mentioned this issue Nov 4, 2021
Merged
@mergify mergify bot closed this as completed in #3121 Nov 6, 2021
mergify bot pushed a commit that referenced this issue Nov 6, 2021
@rix0rrr
fix(pacmak): development version cannot pack java (#3121)
0d9cf51 
When the version of `jsii-pacmak` is `0.0.0`, it will write the following
requirement for `jsii-runtime`: `[,0.0.1)`. There is no version that satisfies
that dependency, so the build fails.

Make an exception: if the version we're trying to install is `^0.0.0`,
translate it to "any old version" instead.

Fixes #3107.


---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pacmak): development version cannot pack java aws/jsii
1 participant
@rix0rrr