Get rid of private API use #350
Comments
rix0rrr
pushed a commit
that referenced
this issue
Feb 1, 2019
Until we can properly tackle #350, freeze the version of the TypeScript compiler to a known-good version right now.
rix0rrr
added a commit
that referenced
this issue
Feb 1, 2019
Don't use the upstream private API function to turn a `CompilerHost` into a `ParseConfigHost` anymore; instead, I copied the implementation, which is simple enough. Fixes #350.
RomainMuller
added a commit
that referenced
this issue
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Merged
RomainMuller
added a commit
that referenced
this issue
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To parse
tsconfig.json, the compiler needs aParseConfigHost, which contains functions to inspect the filesystem. Unlike aCompilerHost, there is no public factory function to create one.There is a private function to turn an existing
CompilerHostinto aParseConfigHostwhich we call today, but we've gotten some signal that this function may be removed in an upcoming version, so we're going to have to implement our ownParseConfigHostsoon.https://github.com/awslabs/jsii/blob/4ecf28ceaaf130bd1622765468bc64a43fbb5efd/packages/jsii/lib/compiler.ts#L262
The text was updated successfully, but these errors were encountered: