feat(runtimes): support JSII_NODE setting #4024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can customize the `node` runtime used by the jsii runtime for java by providing the `JSII_NODE` environment variable. Additionally, this corrects how the child process is spawned so that `JSII_NODE` and `JSII_RUNTIME` can contain spaces (previously, this would result in a spawn error). Added a test to verify the various scenarios work as intended. Fixes #4009
RomainMuller
changed the title
Naumel
approved these changes
Mar 22, 2023
| public void withNoCustomization() { | ||
| final JsiiRuntime runtime = new JsiiRuntime(null, null); | ||
| runtime.getClient().createObject("Object", Collections.emptyList(), Collections.emptyList(), Collections.emptyList()); | ||
| runtime.terminate(); |
There was a problem hiding this comment.
[nit] runtime could be a JsiiRuntimeTest class member and this line fitted into https://junit.org/junit5/docs/5.0.2/api/org/junit/jupiter/api/AfterEach.html
There was a problem hiding this comment.
Yeah but it's not that much duplication and it makes the tests self-contained...
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
|
Merging (with squash)... |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can customize the
noderuntime used by the jsii runtime libraries by providing theJSII_NODEenvironment variable.Additionally, this corrects how the child process is spawned in Java so that
JSII_NODEandJSII_RUNTIMEcan contain spaces (previously, this would result in a spawn error). Added a test to verify the various scenarios work as intended.Fixes #4009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.