feat(jsii-reflect): TypeSystem can be locked to improve reflection performance #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/memoize-ancestor-calls
branch
from
98a420b to
0073c3e
Compare
mrgrain
changed the title
…rformance Memoizes additional calls when the typesystem has been locked.
mrgrain
force-pushed
the
mrgrain/fix/memoize-ancestor-calls
branch
from
0073c3e to
ca03d97
Compare
rix0rrr
approved these changes
Nov 8, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memoizes additional calls that rely on the typesystem to retrieve type instances.
These calls can (theoretically) change when the typesystem is changed.
Therefore we cannot assume it's okay to always memoize the first call.
To workaround this limitation, we introduce a new mechanism to manually
lockthe typesystem once all assemblies are loaded.We then can start memoizing the additional calls.
For example in
awslintthis reduces the runtime againstaws-cdk-libby ~20s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.