Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to recommended target framework moniker (TFM) to net6.0 #4574

Open
2 tasks done
scottschreckengaust opened this issue Jul 18, 2024 · 0 comments
Open
2 tasks done
Labels
feature-request A feature should be added or improved. p2

Comments

@scottschreckengaust
Copy link

Describe the feature

Use recent dotnet TargetFrameworks, https://github.com/dotnet/core:

https://learn.microsoft.com/en-us/dotnet/standard/frameworks

  • net6.0
  • net8.0

Use Case

Although the netcoreapp3.1 target is still a "Latest version", https://learn.microsoft.com/en-us/dotnet/standard/frameworks#latest-versions, the net6.0 and net8.0 are within the current dotnet support frameworks.

Proposed Solution

Options:

  1. Update

    export const TARGET_FRAMEWORK = 'netcoreapp3.1';
    to net6.0 and other requirements as needed.

  2. Apply <TargetFrameworks>netcoreapp3.1;net6.0</TargetFrameworks> and optionally add <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> to remove warnings:

    Although there is a risk in the warning hints:

    ...You may also set true in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.

Other Information

Builds have warnings:

doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later.

A previous attempt #3957 and rollback #3987 exist.

Here are some examples from the warnings:

warning : Microsoft.Extensions.Configuration 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Configuration.Abstractions 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Configuration.Binder doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.DependencyInjection 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.DependencyInjection.Abstractions 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Logging 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Logging.Abstractions 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Logging.Configuration 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Logging.Console 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Options 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Options.ConfigurationExtensions 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : Microsoft.Extensions.Primitives 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : System.Diagnostics.DiagnosticSource 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : System.Text.Encodings.Web 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 
warning : System.Text.Json 8.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own 

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.149.0

Environment details (OS name and version, etc.)

macOS Sonoma 14.5

@scottschreckengaust scottschreckengaust added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 18, 2024
@ashishdhingra ashishdhingra added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants