Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotnet): target netcoreapp3.1 with RollForward #3987

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

RomainMuller
Copy link
Contributor

Issues where encountered with SDK compatibility when the target
was set to net6.0 even when the .NET SDK 6.0 or newer was in
use. I suspect this is because of conflicting framework dependency
requirements across various packages.

Re-target netcoreapp3.1 while setting a roll-forward policy allowing
use of newer major-releases of the SDK when no exact match is found (this
is tested to work correctly for all supported .NET SDK releases by our
automated test suite).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 6, 2023
@RomainMuller
Copy link
Contributor Author

The integration test failure on this run is spurious but cannot be avoided (this is due to our rolling back the TargetFramework, while we have existing artifacts published that only support net6.0. A release will fix that, but we need to skip over the integration tests this time around.

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2023

Merging (with squash)...

@RomainMuller RomainMuller merged commit 461446b into main Mar 6, 2023
@RomainMuller RomainMuller deleted the rmuller/dotnet-target-framework branch March 6, 2023 12:54
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 6, 2023
@cplee
Copy link

cplee commented Mar 6, 2023

This change is causing issues with aws/aws-cdk#23921

I'm unable to package a CDK construct anymore: https://github.com/cdklabs/cdk-ecs-codedeploy/actions/runs/4347270960/jobs/7594403891

@biffgaut
Copy link

biffgaut commented Mar 9, 2023

Our packaging process has broken as well -

Build Logs

@cplee
Copy link

cplee commented Mar 9, 2023

I was able to work through it with latest version of CDK released yesterday (2.68.0) and latest JSII (1.77.0)

@biffgaut
Copy link

biffgaut commented Mar 9, 2023

Upgrading to 2.68.0 fixed it for us as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants