Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: diamond interface inheritance emits double members #525

Closed
rix0rrr opened this issue Jun 7, 2019 · 0 comments · Fixed by #694
Closed

Java: diamond interface inheritance emits double members #525

rix0rrr opened this issue Jun 7, 2019 · 0 comments · Fixed by #694
Labels
bug This issue is a bug. language/java Related to Java bindings

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 7, 2019

In the scenario:

interface A { 
  bla: string
}

interface B extends A{
}

interface C extends A, B {
}

The generated builder for C will have 2 fields named string _bla, and the generated code won't compile.
rix0rrr added a commit to aws/aws-cdk that referenced this issue Jun 7, 2019
@rix0rrr
chore: fix build by fixing route53 definitions
dfbbbee 
Work around aws/jsii#525.
@rix0rrr rix0rrr mentioned this issue Jun 7, 2019
Merged
4 tasks
rix0rrr added a commit to aws/aws-cdk that referenced this issue Jun 7, 2019
@rix0rrr
chore: fix build by fixing route53 definitions (#2788)
5c90256 
Work around aws/jsii#525.
@rix0rrr rix0rrr added bug This issue is a bug. language/java Related to Java bindings labels Jun 13, 2019
@RomainMuller RomainMuller added this to the Java Support milestone Jul 30, 2019
@bmaizels bmaizels mentioned this issue Aug 12, 2019
Merged
RomainMuller pushed a commit that referenced this issue Aug 12, 2019
@bmaizels @RomainMuller
feat(java): overhauled structs with native implementation, builders, …
b0b3fd2 
…... (#694)

Overhauled structs with native implementation, builders, `equals` and `hashCode` and creation from JSII.

Fixes #525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. language/java Related to Java bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(java): overhauled structs with native implementation, builders, ... aws/jsii
2 participants
@RomainMuller @rix0rrr