TypeScript path aliasses #865

Pidz-b · 2019-10-07T08:00:20Z

🚀 Feature Request

Affected Languages

TypeScript or Javascript
Python
Java
.NET (C#, F#, ...)

General Information

JSII Version: AWS CDK 1.11.0 (build 4ed4d96)
Platform: Linux 5.2.11-1-MANJARO

What is the problem?

When running cdk deploy or cdk synth, a path alias defined in in tsconfig.json is not resolved to the correct path.

I have all my CDK code in a folder named <project root>/infra/
In one of my files I import a custom file that abstracts our naming:

import { NameGen } from '@infra/lib/NameGen';

The tsconfig.json paths look like:

{
  "compilerOptions": {
    "paths": {
      "@infra/*": ["infra/*"],
      ....
}

When running CDK, the following error is thrown: Cannot find module '@infra/lib/NameGen'

Apparently JSII does not resolve the path aliasing of the tsconfig correctly?

The text was updated successfully, but these errors were encountered:

RomainMuller · 2019-10-07T09:44:29Z

JSII does not allow you to override it's generated tsconfig.json; and thus currently setting paths is not supported.

Can you please laborite on what the use-case for path aliases is, so we can determine whether this is a feature that we should support?

Pidz-b · 2019-10-07T09:49:15Z

The use case is pretty code.

The only solution for this is to write the relative path out in full:

import { NameGen } from '../../../../infra/lib/NameGen';
import { MatchingStack } from '../../../../infra/MatchingStack';

In the code I generate for AWS lambda, I use path aliases to get rid of relative-path-hell:

require('@lib/bootstrap');
import FreelancerActivatedEventBody from '@event-handlers/FreelancerActivated/FreelancerActivatedEventBody';
import { SnsEventHandler } from '@lib/SnsEventHandler';

It makes the imports a lot more humanreadable and cleans up the code.

I hope clean code is a good enough reason to implement is, as clean code is a high priority for readability and maintainability IMO

eladb · 2019-10-07T10:38:27Z

We should stop including tsconfig.json files in our modules. It's not a good practice. I remember @rix0rrr said there was some reason related to doc generation??

Pidz-b · 2019-10-07T11:49:52Z

We should stop including tsconfig.json files in our modules. It's not a good practice. I remember @rix0rrr said there was some reason related to doc generation??

Is this related to my issue? Or related to the JSII compiler?

Luca-Terrazzan · 2020-04-10T08:48:35Z

This issue is still present in cdk as well (it uses JSII). In my case I would love to use ts paths in order to provide locators for my lambdas code.

RomainMuller · 2020-04-10T14:59:19Z

I'm contemplating whether we should allow user-controlled tsconfig.json (and restrict certain compiler options to maintain the needed compatibility -- for example, target <= "ES2018", module == "CommonJS", etc...). This would allow us not to have to worry about supporting all variants of inputs that tsc supports that users would want...

What do you guys think about this idea?

MrArnoldPalmer · 2020-04-10T18:57:17Z

It seems simple enough to parse a user provided tsconfig.json if present and merge it with the required/default tsconfig for jsii. We should just warn when a user is including some config that is incompatible with JSII and we are overriding it. Or crash with non-zero.

JeremyJonas · 2020-07-03T00:38:48Z

This also effects lerna (yarn workspace) based projects, as workspace packages can not be resolved to src instead of "main" path. Which means workspace packages used in cdk must be built first, rather than using source typescript files. Very annoying.

{
  "compilerOptions": {
    ...
    "baseUrl": "../",
    "paths": {
      "*": ["packages/*/src", "*", "@types/*"]
    }
  },
  "exclude": ["node_modules", "cdk.out", ".out"]
}

RomainMuller · 2020-07-08T11:32:48Z

@JeremyJonas - I'm not sure I understand how your project is set up. The aws/aws-cdk repository uses lerna with yarn and the workflow feels pretty natural to me.

Would you be able to explain your project structure in more tail, or better yet, share a pointer to an example repository that uses it?

JeremyJonas · 2020-07-08T12:29:25Z

@RomainMuller I’ll try to send example code next week when get back to this.

But basically I have a /packages/... with typescript packages. Those packages use the above tsconfig to reference each other. Using the paths they reference the /src code rather than /dist declaration files for type, which works great. These are all included in lerna/yarn workspaces.

I then have a /infra dir at root that is also included as lerna/yarn workspace. It has similar tsconfig file that includes paths but to the ../packages relative to that dir.

But since cdk tsconfig doesn’t support alias paths it doesn’t work. But it does resolve to node_modules symlink of those /packages.

But because node_modules resolution is based on “main” which is /dist/index.d.ts from complies typescript it requires first building all the packages before /infra cdk package can use them.

Hope that makes sense.

Appreciate you guidance and support!

Will provide more details if needed next week.

RomainMuller · 2020-07-09T08:50:04Z

Have you tried out the --project-references option of jsii? If you use that jsii will operate in a mode similar to tsc --build.

JeremyJonas · 2020-07-10T07:55:44Z

@RomainMuller Do you have a example of that working? Docs are pretty sparse on that, only thing I found was aws/aws-cdk#1466. Just tried to setup tsconfig references and same issue, need to build first.

If that is like tsconfig "references", does it have the same limitation of having to build referenced packages before they can be references? https://www.typescriptlang.org/docs/handbook/project-references.html#caveats-for-project-references

If that is the case, basically same issue I have. Currently with my lerna/yarn project everything is in root node_modules, so after building it just works. But with aliases no need to build, can reference src directly :)

bobbyhadz · 2021-03-01T12:30:47Z

This feature would definitely be a quality of life improvement, to avoid doing:

import {x} from '../../../../folder/file'

And to be consistent with frontend imports, I would assume most people don't you relative imports, when working in typescript.

hirenumradia · 2021-03-14T13:30:00Z

I ran into this issue today, Its a shame I have to use relative imports in my microservices. The way my project is structured is as follows.

Tooling

Yarn V2
Workspaces
Lerna

Structure

"Backend package" creates a CDK stack
Each microservice is a separate package included in the "Backend package" as a NestedStack

Problem

Path imports within a microservice are not resolved when running "cdk bootstrap" on the Backend package.

Current Workaround

I am currently using relative imports within the microservices. This makes me sad :(

bigo104 · 2021-07-26T20:46:38Z

Is this issue still a thing?

skymandr · 2021-09-24T11:31:25Z

Is this issue still a thing?

I just ran into it I think, so seemingly, yes. :-/

moltar · 2021-09-24T12:18:44Z

Not an issue in our project anymore.

55Cancri · 2021-10-23T21:47:23Z

@moltar Well how did you solve it then? I am ASTONISHED cdk doesn't support path aliases, which essentially breaks my entire backend workflow. @RomainMuller please add this feature to cdk.

moltar · 2021-10-24T05:12:49Z

@moltar Well how did you solve it then? I am ASTONISHED cdk doesn't support path aliases, which essentially breaks my entire backend workflow. @RomainMuller please add this feature to cdk.

Here's a demo, hope that helps: https://github.com/moltar/cdk-ts-path-mapping

axelra82 · 2022-07-18T12:31:49Z

Kind of surprising that this is still an issue 🤔

As @Pidz-b said

I hope clean code is a good enough reason to implement is, as clean code is a high priority for readability and maintainability IMO

Agreed 100%.

And

In the code I generate for AWS lambda, I use path aliases to get rid of relative-path-hell

Having to install tsconfig-paths and then adding -r tsconfig-paths/register to app in cdk.json as per c6a4993692e5a74d3884f786d8eb282181f0ed92 works, but seems like something that should just work out of the box.

Relative paths are bad practice.

Allow user control of the `baseUrl` and `paths` compiler options in `tsconfig.json` via the `jsii.tsc` stanza in `package.json`. Fixes #865

Allow user control of the `baseUrl` and `paths` compiler options in `tsconfig.json` via the `jsii.tsc` stanza in `package.json`. Fixes #865 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

github-actions · 2022-07-18T14:00:12Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

heiba · 2022-07-22T11:47:30Z

Hello @RomainMuller, thanks for merging this feature as per #3662, this means the next cdk release will include the latest changes in jsii (namely this feature) ?

Pidz-b added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 7, 2019

RomainMuller added feature-request A feature should be added or improved. and removed bug This issue is a bug. labels Oct 7, 2019

SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 18, 2019

SomayaB added style Issues related to coding style module/tools Issues related to the JSII toolkit labels Jan 7, 2020

SomayaB assigned MrArnoldPalmer Jan 7, 2020

MrArnoldPalmer added the effort/large Large work item – several weeks of effort label Feb 12, 2020

MrArnoldPalmer added the p2 label Aug 17, 2020

MrArnoldPalmer removed their assignment Jun 28, 2021

phstc mentioned this issue Mar 4, 2022

Cannot find module a dependency under libs codebrewlab/nx-plugins#9

Open

RomainMuller added a commit that referenced this issue Jul 18, 2022

feat(jsii): allow specifying baseUrl and paths in tsconfig.json

4dae404

Allow user control of the `baseUrl` and `paths` compiler options in `tsconfig.json` via the `jsii.tsc` stanza in `package.json`. Fixes #865

RomainMuller mentioned this issue Jul 18, 2022

feat(jsii): allow specifying baseUrl and paths in tsconfig.json #3662

Merged

mergify bot closed this as completed in #3662 Jul 18, 2022

sabinayakc mentioned this issue Oct 31, 2022

CDKTF tsconfig paths not working hashicorp/terraform-cdk#2237

Closed

firxworx mentioned this issue Mar 19, 2023

cannot use imported stacks and constructs from libs/packages in nx monorepo adrian-goe/nx-aws-cdk-v2#679

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeScript path aliasses #865

TypeScript path aliasses #865

Pidz-b commented Oct 7, 2019 •

edited

Loading

RomainMuller commented Oct 7, 2019

Pidz-b commented Oct 7, 2019 •

edited

Loading

eladb commented Oct 7, 2019

Pidz-b commented Oct 7, 2019

Luca-Terrazzan commented Apr 10, 2020 •

edited

Loading

RomainMuller commented Apr 10, 2020

MrArnoldPalmer commented Apr 10, 2020

JeremyJonas commented Jul 3, 2020

RomainMuller commented Jul 8, 2020

JeremyJonas commented Jul 8, 2020

RomainMuller commented Jul 9, 2020 •

edited

Loading

JeremyJonas commented Jul 10, 2020

bobbyhadz commented Mar 1, 2021

hirenumradia commented Mar 14, 2021

bigo104 commented Jul 26, 2021

skymandr commented Sep 24, 2021

moltar commented Sep 24, 2021

55Cancri commented Oct 23, 2021

moltar commented Oct 24, 2021 •

edited

Loading

axelra82 commented Jul 18, 2022 •

edited

Loading

github-actions bot commented Jul 18, 2022

heiba commented Jul 22, 2022

TypeScript path aliasses #865

TypeScript path aliasses #865

Comments

Pidz-b commented Oct 7, 2019 • edited Loading

🚀 Feature Request

Affected Languages

General Information

What is the problem?

RomainMuller commented Oct 7, 2019

Pidz-b commented Oct 7, 2019 • edited Loading

eladb commented Oct 7, 2019

Pidz-b commented Oct 7, 2019

Luca-Terrazzan commented Apr 10, 2020 • edited Loading

RomainMuller commented Apr 10, 2020

MrArnoldPalmer commented Apr 10, 2020

JeremyJonas commented Jul 3, 2020

RomainMuller commented Jul 8, 2020

JeremyJonas commented Jul 8, 2020

RomainMuller commented Jul 9, 2020 • edited Loading

JeremyJonas commented Jul 10, 2020

bobbyhadz commented Mar 1, 2021

hirenumradia commented Mar 14, 2021

bigo104 commented Jul 26, 2021

skymandr commented Sep 24, 2021

moltar commented Sep 24, 2021

55Cancri commented Oct 23, 2021

moltar commented Oct 24, 2021 • edited Loading

axelra82 commented Jul 18, 2022 • edited Loading

github-actions bot commented Jul 18, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

heiba commented Jul 22, 2022

Pidz-b commented Oct 7, 2019 •

edited

Loading

Pidz-b commented Oct 7, 2019 •

edited

Loading

Luca-Terrazzan commented Apr 10, 2020 •

edited

Loading

RomainMuller commented Jul 9, 2020 •

edited

Loading

moltar commented Oct 24, 2021 •

edited

Loading

axelra82 commented Jul 18, 2022 •

edited

Loading