fix(java,dotnet): abstract properties have concrete implementations #1128
Conversation
The generated code for abstract properties in Java and C# included fully concrete implementations, instead of an abstract declaration. This made it possible to subclass those types without actually implementing those members, resulting in invalid code. This changes the code generation to actually emit the `abstract` keyword and not generate a full concrete implementation. Fixes #240 Fixes #1011
|
This is currently marked as draft because I still have to double-check whether existing test coverage is sufficient to ensure this "works as-is" or not. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Added tests (and fixed the issues they uncovered in the .NET runtime...) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| /// </remarks> | ||
| [JsiiMethod(name: "someMethod", returnsJson: "{\"type\":{\"primitive\":\"string\"}}", parametersJson: "[{\"name\":\"str\",\"type\":{\"primitive\":\"string\"}}]")] | ||
| protected abstract string SomeMethod(string str); | ||
|
|
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
1 similar comment
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
The generated code for abstract properties in Java and C# included fully
concrete implementations, instead of an abstract declaration. This made
it possible to subclass those types without actually implementing those
members, resulting in invalid code.
This changes the code generation to actually emit the
abstractkeywordand not generate a full concrete implementation.
Fixes #240
Fixes #1011
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.