Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): runtime crashes with EAGAIN trying to read from STDIN #1143

Merged
merged 1 commit into from
Dec 19, 2019
Merged

fix(runtime): runtime crashes with EAGAIN trying to read from STDIN #1143

merged 1 commit into from
Dec 19, 2019

Commits on Dec 19, 2019

  1. fix(runtime): runtime crashes with EAGAIN trying to read from STDIN 

    When using node >= 13.2, attempts to synchronously read from STDIN often
result in `EAGAIN` being raised. This is due to the STDIN file
descriptor being opened with `O_NONBLOCK`.

This introduces a temporary workaround that catches the EAGAIN exception
and re-attempts reading from STDIN "immediately". While this is not the
ideal solution, it can be done right away and appears to have minimal
impact on the overall performance of applications.

A longer term fix is to move away from synchronous IO operations, but
this is a significantly mroe involved fix and migth be a while before
this can be delivered. The long term solution is tracked in #1142.

Related to aws/aws-cdk#5187
    @RomainMuller
    RomainMuller committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    aa5bc77 View commit details
    Browse the repository at this point in the history