fix(jsii-diff): detect interfaces inherited via interfaces #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Apr 7, 2020
MrArnoldPalmer
approved these changes
Apr 7, 2020
`jsii-diff` is currently throwing on CDK because it thinks interfaces are being removed from the inheritance chain, even if they've actually been moved to base classes. This is because the `ClassType.getInterfaces()` method of `jsii-reflect` was only returning its direct interfaces, even when run with `inherited=true` (as opposed to recursively returning the interfaces all the way up the tree). Q: Why did you not add a unit test in `jsii-reflect`? A: The set suite of `jsii-reflect` is quite anemic, and basically only tests that we can mostly deduce the types that are present in an assembly. It doesn't have good testing infrastructure for actually asserting things about arbitrary small pieces of typescript, instead it mostly works on the generated assemblies from the `jsii-calc` etc. examples. `jsii-diff` *does* have that testing infrastructure, and so `jsii-diff` serves as the test suite for `jsii-reflect` at the moment...
MrArnoldPalmer
force-pushed
the
huijbers/fix-inherited-interface-lookup
branch
from
80b7236 to
ac6ddc7
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii-diffis currently throwing on CDK because it thinks interfacesare being removed from the inheritance chain, even if they've actually
been moved to base classes.
This is because the
ClassType.getInterfaces()method ofjsii-reflectwas only returning its direct interfaces, even when run with
inherited=true(as opposed to recursively returning the interfacesall the way up the tree).
Q: Why did you not add a unit test in
jsii-reflect?A: The set suite of
jsii-reflectis quite anemic, and basically onlytests that we can mostly deduce the types that are present in an
assembly. It doesn't have good testing infrastructure for actually
asserting things about arbitrary small pieces of typescript, instead it
mostly works on the generated assemblies from the
jsii-calcetc.examples.
jsii-diffdoes have that testing infrastructure, and sojsii-diffserves as the test suite forjsii-reflectat the moment...By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.