Skip to content

chore(deps): upgrade to typescript 3.9.3 #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

chore(deps): upgrade to typescript 3.9.3 #1664

wants to merge 5 commits into from

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented May 13, 2020 •
edited
Loading

Commit Message

chore(deps): upgrade to typescript 3.9.2 (#1664)

BREAKING CHANGES: The TypeScript compiler was upgraded from 3.8 to 3.9,
which includes a few breaking changes. More information can be found on
the TypeScript 3.9 Announcement page:
https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-beta/#breaking-changes

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller
chore(deps): upgrade to typescript 3.9.2
259de29 
BREAKING CHANGES: The TypeScript compiler was upgraded from 3.8 to 3.9,
which includes a few breaking changes. More information can be found on
the TypeScript 3.9 Announcement page:
https://devblogs.microsoft.com/typescript/announcing-typescript-3-9-beta/#breaking-changes
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 13, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 259de29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller
Copy link
Contributor Author

Note that this includes a workaround for microsoft/TypeScript#38542

@RomainMuller RomainMuller added the dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. label May 13, 2020
@RomainMuller RomainMuller self-assigned this May 13, 2020
@RomainMuller RomainMuller requested a review from a team May 13, 2020 15:07
@rix0rrr
Copy link
Contributor

rix0rrr commented May 14, 2020

Fine with accepting this. This caught my eye in the list of breaking changes:

Getters/Setters are No Longer Enumerable

This might have implications for jsii.

rix0rrr
rix0rrr approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since TS contains breaking changes, technically jsii should bump breaking changes? (And therefore CDK should bump breaking changes?)

@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label May 14, 2020
@RomainMuller
Copy link
Contributor Author

Fine with accepting this. This caught my eye in the list of breaking changes:

Getters/Setters are No Longer Enumerable

This might have implications for jsii.

In fact it doesn't... This is a change in the emitted JS code only; in case the compiler is configured to target ES5 or ES2015 -- but jsii mandates an ES2018 target.

@RomainMuller
Copy link
Contributor Author

Since TS contains breaking changes, technically jsii should bump breaking changes? (And therefore CDK should bump breaking changes?)

I'm not sure those breaking changes are actually problematic. The ones that affect us are either TypeScript generating less surprising code in some fringe cases, and type checking improvements that may find previously unseen bugs.

@RomainMuller RomainMuller changed the title chore(deps): upgrade to typescript 3.9.2 chore(deps): upgrade to typescript 3.9.3 May 20, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: be205c1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller
Copy link
Contributor Author

Leaving as pr/do-no-merge until I get a chance to try to build aws/aws-cdk with it to assess whether the breaking changes are material or not (expecting they're not).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 570766a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
  • Commit ID: 93e91e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller RomainMuller deleted the rmuller/tsc-3.9 branch October 20, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@RomainMuller RomainMuller

Labels
contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainMuller @aws-cdk-automation @rix0rrr