Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: support abstract return types #224

Merged
merged 5 commits into from
Sep 13, 2018
Merged

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Sep 12, 2018

Generate a $proxy class for all abstract classes and use them when the return type is abstract,
similar to interface proxies.

This change also adds abstract: true to all interface members, so the proxy generator can treat interfaces and classes polymorphically.

Added a compliance test "returnAbstract" which verifies this behavior.

Fixes #220
Related to #223 (.NET)
Related to aws/aws-cdk#680 (require jsii update)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Generate a $proxy class for all abstract classes
and use them when the return type is abstract,
similar to interface proxies.

This change also adds "abstract: true" to all
interface members, so the proxy generator can
treat interfaces and classes polymorphically.

Added a compliance test "returnAbstract" which
verifies this behavior.

Fixes #220
Related to #223 (.NET)
Related to aws/aws-cdk#680 (require jsii update)
@eladb eladb merged commit 3257223 into master Sep 13, 2018
@eladb eladb deleted the benisrae/java-return-abstract branch September 13, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants