fix(jsii): unknown error in Assembler._validateHeritageClauses #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the source code does not compile due to type checking errors, the TypeScript program model may include "error type" placeholders, to allow the compiler to provide feedback on subsequent code. The placeholder types do not have a symbol (quite intentionally!), and will hence cause a failure in the `Assembler.validateHeritageClauses` method. This change makes the code more defensive so it does not crash on this symptom, and does not report an additional error either (the TypeScript compiler will have done this for us already). The bug is more likely to hit users operating under `--watch`, as the type checker is more likely to be able to insert placeholder types in this case, as a previous version of the program might be used as a crutch to understand the error's context... This makes this bug difficult to reproduce in lab conditions, and is why this change does not include a corresponding unit test. Fixes #2349
eladb
approved these changes
Dec 14, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source code does not compile due to type checking errors, the
TypeScript program model may include "error type" placeholders, to allow
the compiler to provide feedback on subsequent code. The placeholder
types do not have a symbol (quite intentionally!), and will hence cause
a failure in the
Assembler.validateHeritageClausesmethod.This change makes the code more defensive so it does not crash on this
symptom, and does not report an additional error either (the TypeScript
compiler will have done this for us already).
The bug is more likely to hit users operating under
--watch, as thetype checker is more likely to be able to insert placeholder types in
this case, as a previous version of the program might be used as a
crutch to understand the error's context... This makes this bug
difficult to reproduce in lab conditions, and is why this change does
not include a corresponding unit test.
Fixes #2349
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.