Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate NuGet symbol and source packages #243

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Generate NuGet symbol and source packages #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d2e0f
Generate NuGet symbol and source packages
christophercurrie Sep 22, 2018
b5a192e
Merge remote-tracking branch 'origin/master' into dotnet-symbols-source
RomainMuller Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/jsii-dotnet-generator/NuGet.Metadata.props.t.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ const package = require('./package.json');
process.stdout.write(`<Project>
<PropertyGroup>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<IncludeSymbols>True</IncludeSymbols>
<IncludeSource>True</IncludeSource>
<PackageOutputPath>..\\..\\bin\\$(Configuration)\\NuGet\\</PackageOutputPath>
<PackageVersion>$(JsiiVersion)</PackageVersion>
<Description>${package.description}</Description>
Expand Down
2 changes: 2 additions & 0 deletions ...ages/jsii-dotnet-generator/src/Amazon.JSII.Generator.UnitTests/AssemblyExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,8 @@ public void IncludesAllPresentProperties()
Assert.Collection(actual,
element => Assert.Equal("<TargetFramework>netstandard2.0</TargetFramework>", element.ToString()),
element => Assert.Equal("<GeneratePackageOnBuild>true</GeneratePackageOnBuild>", element.ToString()),
element => Assert.Equal("<IncludeSymbols>True</IncludeSymbols>", element.ToString()),
element => Assert.Equal("<IncludeSource>True</IncludeSource>", element.ToString()),
element => Assert.Equal("<PackageVersion>1.2.3</PackageVersion>", element.ToString()),
element => Assert.Equal("<PackageId>My.PackageId</PackageId>", element.ToString()),
element => Assert.Equal("<Description>my description</Description>", element.ToString()),
Expand Down
2 changes: 2 additions & 0 deletions packages/jsii-dotnet-generator/src/Amazon.JSII.Generator.UnitTests/AssemblyGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,8 @@ public void CreatesBasicProjectFile()
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<IncludeSymbols>true</IncludeSymbols>
<IncludeSource>true</IncludeSource>
<Authors>myAuthors</Authors>
<Company>myCompany</Company>
<PackageVersion>1.2.3</PackageVersion>
Expand Down
2 changes: 2 additions & 0 deletions packages/jsii-dotnet-generator/src/Amazon.JSII.Generator/AssemblyExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ public static IEnumerable<XElement> GetMsBuildProperties(this Assembly assembly)
{
yield return new XElement("TargetFramework", "netstandard2.0");
yield return new XElement("GeneratePackageOnBuild", true);
yield return new XElement("IncludeSymbols", true);
yield return new XElement("IncludeSource", true);
yield return new XElement("PackageVersion", assembly.Version);
yield return new XElement("PackageId", assembly.Targets.DotNet.PackageId);
yield return new XElement("Description", assembly.Description);
Expand Down
2 changes: 2 additions & 0 deletions packages/jsii-dotnet-jsonmodel/NuGet.Metadata.props.t.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ const package = require('./package.json');
process.stdout.write(`<Project>
<PropertyGroup>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<IncludeSymbols>True</IncludeSymbols>
<IncludeSource>True</IncludeSource>
<PackageOutputPath>..\\..\\bin\\$(Configuration)\\NuGet\\</PackageOutputPath>
<PackageVersion>$(JsiiVersion)</PackageVersion>
<Description>${package.description}</Description>
Expand Down
2 changes: 2 additions & 0 deletions packages/jsii-dotnet-runtime/NuGet.Metadata.props.t.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ const package = require('./package.json');
process.stdout.write(`<Project>
<PropertyGroup>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<IncludeSymbols>True</IncludeSymbols>
<IncludeSource>True</IncludeSource>
<PackageOutputPath>..\\..\\bin\\$(Configuration)\\NuGet\\</PackageOutputPath>
<PackageVersion>$(JsiiVersion)</PackageVersion>
<Description>${package.description}</Description>
Expand Down
2 changes: 2 additions & 0 deletions ...culatorPackageId.BasePackageId/Amazon.JSII.Tests.CalculatorPackageId.BasePackageId.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<IncludeSymbols>true</IncludeSymbols>
<IncludeSource>true</IncludeSource>
<PackageVersion>0.7.13</PackageVersion>
<PackageId>Amazon.JSII.Tests.CalculatorPackageId.BasePackageId</PackageId>
<Description>An example direct dependency for jsii-calc.</Description>
Expand Down
2 changes: 2 additions & 0 deletions ...alculatorPackageId.LibPackageId/Amazon.JSII.Tests.CalculatorPackageId.LibPackageId.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<IncludeSymbols>true</IncludeSymbols>
<IncludeSource>true</IncludeSource>
<PackageVersion>0.7.13</PackageVersion>
<PackageId>Amazon.JSII.Tests.CalculatorPackageId.LibPackageId</PackageId>
<Description>A simple calcuator library built on JSII.</Description>
Expand Down
2 changes: 2 additions & 0 deletions ...dotnet/Amazon.JSII.Tests.CalculatorPackageId/Amazon.JSII.Tests.CalculatorPackageId.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<IncludeSymbols>true</IncludeSymbols>
<IncludeSource>true</IncludeSource>
<PackageVersion>0.7.13</PackageVersion>
<PackageId>Amazon.JSII.Tests.CalculatorPackageId</PackageId>
<Description>A simple calcuator built on JSII.</Description>
Expand Down