Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): examples with multi-line strings produce invalid python docstrings #2571

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Feb 14, 2021

Since docstrings are now rendered inside single-quoted multiline strings to allow the docstring itself to include example code with double-quoted multiline string literals. Those are the ones produced by rosetta for python.

Fixes #2569


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…docstrings

Since docstrings are now rendered inside single-quoted multiline strings to allow the docstring itself to include example code with double-quoted multiline string literals. Those are the ones produced by rosetta for python.

Fixes #2569
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 14, 2021
@eladb eladb merged commit d5c2e3a into main Feb 15, 2021
@eladb eladb deleted the benisrae/single-quote-docstrings branch February 15, 2021 09:20
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-6Jw05QLuWWwe
  • Commit ID: e6eafaf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python: newlines in literal strings example code results in invalid syntax
3 participants