Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): invalid code when multi-inheriting optional properties #2591

Merged
merged 4 commits into from
Feb 22, 2021

Commits on Feb 19, 2021

  1. fix(java): invalid code when multi-inheriting optional properties

    The generated code for interfaces includes default implementations for
    optional properties (since adding a new optional property is a non
    breaking change in TypeScript, this allows us to preserve this property
    in Java, too).
    
    However, if two distinct super-interfaces declare the same property, the
    child inherits two unrelated default implementations for the same
    method, which results in dispatch ambiguity that is illegal.
    
    In order to remove the ambiguity, a new default implementation must be
    provided on the child interface, so that the dispatch is unambiguous
    again.
    
    Fixes #22556
    RomainMuller committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    9ea2aef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a13ea4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Update packages/jsii-pacmak/lib/targets/java.ts

    Co-authored-by: Niranjan Jayakar <nija@amazon.com>
    RomainMuller and Niranjan Jayakar authored Feb 22, 2021
    Configuration menu
    Copy the full SHA
    21bfabc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f94889 View commit details
    Browse the repository at this point in the history