Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeError when trying to use bin-scripts in Python #2720

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

kozlove-aws
Copy link
Contributor

Problem

Bin script on Python is failing with error The "path" argument must be of type string. Received undefined

Solution

  • Changed parameter name pkgname on assembly in InvokeScriptRequest
  • Returned response from invokeBinScript (used for printing output)

Testing

Running bin script with these change and make sure that bin scripts are running.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 18, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2021

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2021

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2021

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@RomainMuller RomainMuller changed the title fix: Fixing executing bin scripts for Python. fix: TypeError when trying to use bin-scripts in Python Mar 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Merging (with squash)...

@RomainMuller RomainMuller merged commit acdf1a9 into aws:main Mar 22, 2021
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants