Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime/dotnet): Correct a number of type mappings #291

Merged
merged 3 commits into from
Nov 6, 2018

Commits on Nov 5, 2018

  1. fix(runtime/dotnet): Correct a number of type mappings

    The `jsii` compiler incorrectly mapped types homonym with a standard
    type (`String`, `Number`, ...) to the primitive type on usage sites.
    This commit corrects this behavior and adjusts the C# tests accordingly.
    
    Additionally, when the return type of a callback was an interface, the
    C# runtime was unable to determine the correct JSII type to use, despite
    it has the information on the type of the callback method available. The
    resolution behavior has also been fixes, as well as a couple of other
    glitches that became apparent as a result of the `Number` type starting
    to be correctly represented as the `@scope/jsii-calc-lib.Number` type.
    
    Fixes #290
    Fixes aws/aws-cdk#1027
    RomainMuller committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    e15919b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. Configuration menu
    Copy the full SHA
    c127be4 View commit details
    Browse the repository at this point in the history
  2. Fix broken tests

    RomainMuller committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    483309b View commit details
    Browse the repository at this point in the history