Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade baseline node requirement to >=12.7.0 #2946

Merged
merged 15 commits into from
Sep 14, 2021
Merged

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Aug 10, 2021

Node 10.x has been end-of-lifed on 2021-04-30, and it is more than
time to drop support for it entirely. Per our support policy, only
current releases of runtimes are supported, and hence we are at liberty
to make this change without incurring a major version bump.

BREAKING CHANGE: the minimum supported version of node changed from
10.3.0 to 12.7.0. We recommend using 16.x if possible.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Node 10.x has been end-of-lifed on `2021-04-30`, and it is more than
time to drop support for it entirely. Per our support policy, only
current releases of runtimes are supported, and hence we are at liberty
to make this change without incurring a major version bump.

BREAKING CHANGE: the minimum supported version of `node` changed from
`10.3.0` to `12.4.0`. We recommend using `16.x` if possible.
@RomainMuller RomainMuller requested a review from a team August 10, 2021 10:41
@RomainMuller RomainMuller self-assigned this Aug 10, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 10, 2021
@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label Aug 10, 2021
@RomainMuller
Copy link
Contributor Author

This should not ship before the deadline set in #2948 has expired.

@RomainMuller RomainMuller changed the title chore: upgrade baseline node requirement to >=12.4.0 chore: upgrade baseline node requirement to >=12.7.0 Aug 11, 2021
# Conflicts:
#	.github/workflows/yarn-upgrade.yml
#	packages/@jsii/dotnet-runtime-test/package.json
#	packages/@jsii/dotnet-runtime/package.json
#	packages/@jsii/go-runtime/package.json
#	packages/@jsii/integ-test/package.json
#	packages/@jsii/java-runtime/package.json
#	packages/@jsii/kernel/package.json
#	packages/@jsii/runtime/package.json
#	packages/@jsii/spec/package.json
#	packages/@scope/jsii-calc-base-of-base/package.json
#	packages/@scope/jsii-calc-base/package.json
#	packages/@scope/jsii-calc-lib/package.json
#	packages/codemaker/package.json
#	packages/jsii-calc/package.json
#	packages/jsii-config/package.json
#	packages/jsii-diff/package.json
#	packages/jsii-pacmak/package.json
#	packages/jsii-reflect/package.json
#	packages/jsii-rosetta/package.json
#	packages/jsii/package.json
#	packages/oo-ascii-tree/package.json
#	tools/jsii-compliance/package.json
#	yarn.lock
# Conflicts:
#	.github/workflows/docker-images.yml
#	superchain/Dockerfile
#	superchain/README.md
#	superchain/build-local.sh
@RomainMuller RomainMuller merged commit f2c6842 into main Sep 14, 2021
@RomainMuller RomainMuller deleted the rmuller/node-12 branch September 14, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants