-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade baseline node requirement to >=12.7.0 #2946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 10.x has been end-of-lifed on `2021-04-30`, and it is more than time to drop support for it entirely. Per our support policy, only current releases of runtimes are supported, and hence we are at liberty to make this change without incurring a major version bump. BREAKING CHANGE: the minimum supported version of `node` changed from `10.3.0` to `12.4.0`. We recommend using `16.x` if possible.
RomainMuller
added
the
pr/do-not-merge
This PR should not be merged at this time.
label
Aug 10, 2021
This should not ship before the deadline set in #2948 has expired. |
RomainMuller
changed the title
chore: upgrade baseline node requirement to >=12.4.0
chore: upgrade baseline node requirement to >=12.7.0
Aug 11, 2021
# Conflicts: # .github/workflows/yarn-upgrade.yml # packages/@jsii/dotnet-runtime-test/package.json # packages/@jsii/dotnet-runtime/package.json # packages/@jsii/go-runtime/package.json # packages/@jsii/integ-test/package.json # packages/@jsii/java-runtime/package.json # packages/@jsii/kernel/package.json # packages/@jsii/runtime/package.json # packages/@jsii/spec/package.json # packages/@scope/jsii-calc-base-of-base/package.json # packages/@scope/jsii-calc-base/package.json # packages/@scope/jsii-calc-lib/package.json # packages/codemaker/package.json # packages/jsii-calc/package.json # packages/jsii-config/package.json # packages/jsii-diff/package.json # packages/jsii-pacmak/package.json # packages/jsii-reflect/package.json # packages/jsii-rosetta/package.json # packages/jsii/package.json # packages/oo-ascii-tree/package.json # tools/jsii-compliance/package.json # yarn.lock
# Conflicts: # .github/workflows/docker-images.yml # superchain/Dockerfile # superchain/README.md # superchain/build-local.sh
eladb
approved these changes
Sep 13, 2021
Chriscbr
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution/core
This is a PR that came from AWS.
pr/do-not-merge
This PR should not be merged at this time.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 10.x has been end-of-lifed on
2021-04-30
, and it is more thantime to drop support for it entirely. Per our support policy, only
current releases of runtimes are supported, and hence we are at liberty
to make this change without incurring a major version bump.
BREAKING CHANGE: the minimum supported version of
node
changed from10.3.0
to12.7.0
. We recommend using16.x
if possible.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.